Re: [PATCH] wt-status: move #include "pathspec.h" to the header

2015-08-20 Thread SZEDER Gábor
Quoting Junio C Hamano : SZEDER Gábor writes: The declaration of 'struct wt_status' requires the declararion of 'struct pathspec'. I think this is fine. I am guessing that you are saying it is wrong to force wt-status.c to include pathspec.h before including wt-status.h; I am fine with th

Re: [PATCH] wt-status: move #include "pathspec.h" to the header

2015-08-20 Thread Jeff King
On Thu, Aug 20, 2015 at 12:05:34PM -0700, Junio C Hamano wrote: > This is a tangent, but the above is different from saying that with > a single liner test.c that has > > #include "wt-status.h" > > your compilation "cc -c test.c" should succeed. But for that goal, > direct inclusion of to

Re: [PATCH] wt-status: move #include "pathspec.h" to the header

2015-08-20 Thread Junio C Hamano
SZEDER Gábor writes: > The declaration of 'struct wt_status' requires the declararion of 'struct > pathspec'. I think this is fine. I am guessing that you are saying it is wrong to force wt-status.c to include pathspec.h before including wt-status.h; I am fine with that. This is a tangent, but