Re: [PATCH] worktree add: be tolerant of corrupt worktrees

2019-06-01 Thread Shaheed Haque
On Sat, 18 May 2019 at 12:50, Duy Nguyen wrote: > > On Fri, May 17, 2019 at 2:46 PM Eric Sunshine wrote: > > > > On Mon, May 13, 2019 at 6:50 AM Nguyễn Thái Ngọc Duy > > wrote: > > > find_worktree() can die() unexpectedly because it uses real_path() > > > instead of the gentler version. When it

Re: [PATCH] worktree add: be tolerant of corrupt worktrees

2019-05-18 Thread Duy Nguyen
On Fri, May 17, 2019 at 2:46 PM Eric Sunshine wrote: > > On Mon, May 13, 2019 at 6:50 AM Nguyễn Thái Ngọc Duy > wrote: > > find_worktree() can die() unexpectedly because it uses real_path() > > instead of the gentler version. When it's used in 'git worktree add' [1] > > and there's a bad worktre

Re: [PATCH] worktree add: be tolerant of corrupt worktrees

2019-05-17 Thread Eric Sunshine
On Mon, May 13, 2019 at 6:50 AM Nguyễn Thái Ngọc Duy wrote: > find_worktree() can die() unexpectedly because it uses real_path() > instead of the gentler version. When it's used in 'git worktree add' [1] > and there's a bad worktree, this die() could prevent people from adding > new worktrees. Th

Re: [PATCH] worktree add: be tolerant of corrupt worktrees

2019-05-13 Thread Shaheed Haque
Hi Nguyễn, Thanks for the quick response. While I leave the code to the experts, I can confirm that restoring the missing directory (but no content in it) does allow "worktree add" to function again. One point may be worth clarifying... On Mon, 13 May 2019 at 11:50, Nguyễn Thái Ngọc Duy wrote: