Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
> Then the next step (as outlined by Documentation/SubmittingPatches) > is to figure out how to best present this to the mailing list; I think the > best > way is to send out a patch series consisting of both of these 2 patches, > the "connect_work_tree_and_git_dir: safely create leading directori

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 3:24 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> Also, >>> should I start new thread for new patch series? >> >> As you like. >> As far as I understand, it is very easy for Junio to take a whole >> (sub-)thread of patches and apply that and make a branch with >>

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: >> Also, >> should I start new thread for new patch series? > > As you like. > As far as I understand, it is very easy for Junio to take a whole > (sub-)thread of patches and apply that and make a branch with > multiple commits out of it as he has tooling for that. Note tha

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 3:05 PM, Valery Tolstov wrote: >> Then the next step (as outlined by Documentation/SubmittingPatches) >> is to figure out how to best present this to the mailing list; I think the >> best >> way is to send out a patch series consisting of both of these 2 patches, >> the "co

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 11:59 AM, Valery Tolstov wrote: >> Maybe we need to have 2293f77a081 >> (connect_work_tree_and_git_dir: safely create leading directories, >> part of origin/sb/checkout-recurse-submodules, also found at >> https://public-inbox.org/git/20170306205919.9713-8-sbel...@google.com

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
> Maybe we need to have 2293f77a081 > (connect_work_tree_and_git_dir: safely create leading directories, > part of origin/sb/checkout-recurse-submodules, also found at > https://public-inbox.org/git/20170306205919.9713-8-sbel...@google.com/ ) > first before we can apply this patch. Thank you for y

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 9:44 AM, wrote: > From: Valery Tolstov > > Remove code fragment from module_clone that duplicates functionality > of connect_work_tree_and_git_dir in dir.c > > Signed-off-by: Valery Tolstov > --- >>> I think we can reuse code from module_clone that writes .git link. >>> P