Re: [PATCH] stash: fix handling removed files with --keep-index

2019-07-16 Thread Junio C Hamano
Thomas Gummerer writes: > On 07/11, Junio C Hamano wrote: >> Thomas Gummerer writes: >> >> > Fix that behaviour by using 'git restore' which can faithfully restore >> > the index and working tree. This also simplifies the code. >> >> Hmph. I would have preferred to see we stayed away from 'r

Re: [PATCH] stash: fix handling removed files with --keep-index

2019-07-16 Thread Thomas Gummerer
On 07/11, Junio C Hamano wrote: > Thomas Gummerer writes: > > > Fix that behaviour by using 'git restore' which can faithfully restore > > the index and working tree. This also simplifies the code. > > Hmph. I would have preferred to see we stayed away from 'restore' > (and used 'checkout' ins

Re: [PATCH] stash: fix handling removed files with --keep-index

2019-07-11 Thread Junio C Hamano
Thomas Gummerer writes: > Fix that behaviour by using 'git restore' which can faithfully restore > the index and working tree. This also simplifies the code. Hmph. I would have preferred to see we stayed away from 'restore' (and used 'checkout' instead, if you must use a Porcelain command), so