Re: [PATCH] sha1dc: fix issues with a big endian platform

2017-05-17 Thread Johannes Schindelin
Hi Junio, On Wed, 17 May 2017, Junio C Hamano wrote: > diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c > index 35e9dd5bf4..ae25318c47 100644 > --- a/sha1dc/sha1.c > +++ b/sha1dc/sha1.c > @@ -20,7 +20,7 @@ > */ > #if (defined(__BYTE_ORDER) && (__BYTE_ORDER == __BIG_ENDIAN)) || \ > (defined(__BY

Re: [PATCH] sha1dc: fix issues with a big endian platform

2017-05-17 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, May 17, 2017 at 7:39 AM, Junio C Hamano wrote: >> From: Marc Stevens >> >> Some big-endian platforms define _BIG_ENDIAN, which the test at the >> beginning of file has missed. Also, when the input is not aligned, >> some platforms trigger SIGBUS. >> >>

Re: [PATCH] sha1dc: fix issues with a big endian platform

2017-05-16 Thread Ævar Arnfjörð Bjarmason
On Wed, May 17, 2017 at 7:39 AM, Junio C Hamano wrote: > From: Marc Stevens > > Some big-endian platforms define _BIG_ENDIAN, which the test at the > beginning of file has missed. Also, when the input is not aligned, > some platforms trigger SIGBUS. > > This change corresponds to 33a694a9 ("Fix