Re: [PATCH] repack: enable bitmaps by default on bare repos

2019-03-13 Thread Jeff King
On Wed, Mar 13, 2019 at 01:51:33AM +, Eric Wong wrote: > But I did find Ævar's forgotten gitperformance doc and thread > where the topic was brought up: > > https://public-inbox.org/git/20170403211644.26814-1-ava...@gmail.com/ One thing that thread reminded me of: we probably also want to

Re: [PATCH] repack: enable bitmaps by default on bare repos

2019-03-12 Thread Eric Wong
Jeff King wrote: > OK. I still think of bitmaps as something that might need manual care > and feeding, but I think that may be leftover superstition. I can't > offhand think of any real downsides to this. It's a _relatively_ new feature to long-time users like us, so maybe the "new == immature"

Re: [PATCH] repack: enable bitmaps by default on bare repos

2019-03-12 Thread Jeff King
On Tue, Mar 12, 2019 at 06:49:54AM -0400, Jeff King wrote: > I'm not sure what we're trying to accomplish with this unpacking, > though. Running "git repack -ad" should generate bitmaps whether the > objects were already in a single pack or not. So I think this test can > just be: > > git clone

Re: [PATCH] repack: enable bitmaps by default on bare repos

2019-03-12 Thread Jeff King
On Tue, Mar 12, 2019 at 03:13:03AM +, Eric Wong wrote: > > I do think they're a net win for people hosting git servers. But if > > that's the goal, I think at most you'd want to make bitmaps the default > > for bare repos. They're really not much help for normal end-user repos > > at this poin

Re: [PATCH] repack: enable bitmaps by default on bare repos

2019-03-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 12 2019, Eric Wong wrote: > Jeff King wrote: >> On Sat, Mar 09, 2019 at 02:49:44AM +, Eric Wong wrote: >> > It would make life easier for people new to hosting git servers >> > (and hopefully reduce centralization :) >> >> I do think they're a net win for people hosting git serv