Re: [PATCH] push: shorten "push.default is unset" warning message

2016-02-24 Thread Jeff King
On Tue, Feb 23, 2016 at 11:05:08AM -0800, Junio C Hamano wrote: > If most people are happy with "simple" (and certainly that was the > assumption and hope behind the transtion we made at 2.0), we may be > better off removing the warning altogether. Keeping "and adopt the > new behaviour" part pre

Re: [PATCH] push: shorten "push.default is unset" warning message

2016-02-23 Thread Matthieu Moy
"Philip Oakley" writes: > Shouldn't this also update the 'push' man page to state what the new > default is. @gerry's comment to the top answer > http://stackoverflow.com/a/13148313/717355 highlights that the word > 'simple' is not even mentioned in the 'push' man page. This is more or less a di

Re: [PATCH] push: shorten "push.default is unset" warning message

2016-02-23 Thread Philip Oakley
From: "Matthieu Moy" From: Matthieu Moy The warning was purposely long, both to explain the situation properly and to give a strong incentive to set push.default explicitly. This was important before the 2.0 transition, and remained important for a while after, so that new users get push.defau

Re: [PATCH] push: shorten "push.default is unset" warning message

2016-02-23 Thread Matthieu Moy
Junio C Hamano writes: > The punchline of that question is: > > I can obviously set it to one of the values mentioned, but what do > they mean? What's the difference between simple and matching? > > It tells us that "See 'git help config'" is not such an effective > message to help such a

Re: [PATCH] push: shorten "push.default is unset" warning message

2016-02-23 Thread Junio C Hamano
Matthieu Moy writes: > The warning is mostly seen by beginners, who have not set their > push.default configuration (yet). For many of them, the warning is > confusing because it talks about concepts that they have not learned and > asks them a choice that they are not able to make yet. See for e