Re: [PATCH] perf: amend the grep tests to test grep.threads

2018-01-05 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> Judging by the way the other side uses "test_perf $prereq ..." >> without quotes around it, I suspect you do expect it to be empty in >> some cases. It means you expect test_have_prereq is prepared to >> skip an empty prerequisite in a prereq list, but I do not

Re: [PATCH] perf: amend the grep tests to test grep.threads

2018-01-05 Thread Ævar Arnfjörð Bjarmason
On Thu, Jan 04 2018, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason writes: > >> Ever since 5b594f457a ("Threaded grep", 2010-01-25) the number of >> threads git-grep uses under PTHREADS has been hardcoded to 8, but >> there's no performance test to check whether this is an optimal >> settin

Re: [PATCH] perf: amend the grep tests to test grep.threads

2018-01-04 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Ever since 5b594f457a ("Threaded grep", 2010-01-25) the number of > threads git-grep uses under PTHREADS has been hardcoded to 8, but > there's no performance test to check whether this is an optimal > setting. > > Amend the existing tests for the grep engines t