Re: [PATCH] pathspec: removed unnecessary function prototypes

2016-09-14 Thread Brandon Williams
On Wed, Sep 14, 2016 at 12:23 PM, Jeff King wrote: > On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote: > I should have done a better job of not just providing the answer, but > showing how. The easiest tool here is "git log -S": > > git log -1 -p -Scheck_path_for_gitlink > > (and then

Re: [PATCH] pathspec: removed unnecessary function prototypes

2016-09-14 Thread Jeff King
On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote: > On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote: > > > removed function prototypes from pathspec.h which don't have a > > corresponding implementation. > > I'm always curious of the "why" in cases like this. Did we for

Re: [PATCH] pathspec: removed unnecessary function prototypes

2016-09-13 Thread Junio C Hamano
Jeff King writes: > On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote: > >> removed function prototypes from pathspec.h which don't have a >> corresponding implementation. > > I'm always curious of the "why" in cases like this. Did we forget to add > them? Did they get renamed? Did

Re: [PATCH] pathspec: removed unnecessary function prototypes

2016-09-13 Thread Jeff King
On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote: > removed function prototypes from pathspec.h which don't have a > corresponding implementation. I'm always curious of the "why" in cases like this. Did we forget to add them? Did they get renamed? Did they go away? Looks like the