Re: [PATCH] notes: avoid leaking duplicate entries

2019-08-25 Thread Mike Hommey
On Sun, Aug 25, 2019 at 02:18:18PM +0900, Mike Hommey wrote: > When add_note is called multiple times with the same key/value pair, the > leaf_node it creates is leaked by notes_tree_insert. For completeness, since I realized it was missing: Signed-off-by: Mike Hommey Mike

Re: [PATCH] notes: avoid leaking duplicate entries

2019-08-25 Thread Jeff King
On Sun, Aug 25, 2019 at 02:18:18PM +0900, Mike Hommey wrote: > When add_note is called multiple times with the same key/value pair, the > leaf_node it creates is leaked by notes_tree_insert. Makes sense. > diff --git a/notes.c b/notes.c > index 75c028b300..ec35f5b551 100644 > --- a/notes.c > +++