Re: [PATCH] grep: skip UTF8 checks explicitly

2019-07-24 Thread Junio C Hamano
Johannes Schindelin writes: > My reading of the situation is slightly different. I think > PCRE_NO_UTF8_CHECK is off by default, but it only makes a difference in > the non-JIT'ed code path. Since we use PCRE2's JIT when possible > (because it leads to a quite nice performance improvement), we us

Re: [PATCH] grep: skip UTF8 checks explicitly

2019-07-24 Thread Johannes Schindelin
Hi Junio, On Tue, 23 Jul 2019, Junio C Hamano wrote: > Carlo Marcelo Arenas Belón writes: > > > Usually PCRE is compiled with JIT support, and therefore the code > > path used includes calling pcre2_jit_match (for PCRE2), that ignores > > invalid UTF-8 in the corpus. > > > > Make that option ex

Re: [PATCH] grep: skip UTF8 checks explicitly

2019-07-23 Thread Junio C Hamano
Carlo Marcelo Arenas Belón writes: > Usually PCRE is compiled with JIT support, and therefore the code > path used includes calling pcre2_jit_match (for PCRE2), that ignores > invalid UTF-8 in the corpus. > > Make that option explicit so it can be also used when JIT is not > enabled and pcre2_ma