Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-19 Thread Junio C Hamano
Andrew Keller writes: > When displaying a blob in gitweb, if it's an image, specify constraints for > maximum display width and height to prevent the image from overflowing the > frame of the enclosing page_body div. > > This change assumes that it is more desirable to see the whole image without

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Tony Finch
Andrew Keller wrote: > > With that said, I don't think it's unreasonable for a software project > to contain images larger than a browser window. And, when that happens, > I'm pretty confident that the default behavior should be to scale the > image down so the user can see the whole thing. Righ

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Andrew Keller
On Feb 7, 2014, at 7:35 AM, Vincent van Ravesteijn wrote: > On Fri, Feb 7, 2014 at 4:31 AM, Andrew Keller wrote: >> I recently used Git to archive a set of scanned photos, and I used gitweb to >> provide access to them. Overall, everything worked well, but I found it >> undesirable that I had

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Vincent van Ravesteijn
On Fri, Feb 7, 2014 at 4:31 AM, Andrew Keller wrote: > I recently used Git to archive a set of scanned photos, and I used gitweb to > provide access to them. Overall, everything worked well, but I found it > undesirable that I had to zoom out in my browser on every photo to see the > whole pho

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Andrew Keller
On Feb 6, 2014, at 10:31 PM, Andrew Keller wrote: > When displaying a blob in gitweb, if it's an image, specify constraints for > maximum display width and height to prevent the image from overflowing the > frame of the enclosing page_body div. > > This change assumes that it is more desirable to