Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-13 Thread Junio C Hamano
Pratyush Yadav writes: >> The Git community members needs to be able to trust that the new >> Git-gui maintainer would make a sensible decision when picking up >> (or asking to improve) a patch from the list to collect and forward >> to me. We somehow need to make sure that happens. > > Yes, b

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-13 Thread Pratyush Yadav
On 09/08/19 01:03PM, Junio C Hamano wrote: > Pratyush Yadav writes: > > >> If you meant to volunteer to act as a git-gui maintainer, that would > >> be wonderful. Then I do not have to play an interim maintainer. > > > > Yes, I do mean to volunteer to act as a git-gui maintainer. > > > > Is ther

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-09 Thread Junio C Hamano
Pratyush Yadav writes: >> If you meant to volunteer to act as a git-gui maintainer, that would >> be wonderful. Then I do not have to play an interim maintainer. > > Yes, I do mean to volunteer to act as a git-gui maintainer. > > Is there something I should know other than > Documentation/howto/

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-09 Thread Pratyush Yadav
On 8/8/19 3:23 AM, Junio C Hamano wrote: Pratyush Yadav writes: I think you misunderstood me. I do not mean to create a GitHub pull request, because as you say, no one other than me and you will look at it. What I meant was that I can pile up a bunch of commits, and send them on this list here

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-07 Thread Junio C Hamano
Pratyush Yadav writes: > I think you misunderstood me. I do not mean to create a GitHub pull > request, because as you say, no one other than me and you will look at > it. What I meant was that I can pile up a bunch of commits, and send > them on this list here for you to merge. I can explain tho

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-07 Thread Pratyush Yadav
On 8/7/19 11:20 PM, Junio C Hamano wrote: Pratyush Yadav writes: So if I fork the project, will you pull from my fork? If yes, what exactly would I have to do? Make a set of changes and then ask on the list for you to pull from my fork? I am a relatively inexperienced programmer, and it feels

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-07 Thread Junio C Hamano
Pratyush Yadav writes: > So if I fork the project, will you pull from my fork? If yes, what > exactly would I have to do? Make a set of changes and then ask on the > list for you to pull from my fork? > > I am a relatively inexperienced programmer, and it feels like a kinda > big responsibility t

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-07 Thread Junio C Hamano
Junio C Hamano writes: > Pratyush Yadav writes: > >> I'm not too optimistic on finding someone to run this project. I asked >> on the list who the maintainer is [0], and no one came up. The repo at >> [1] also seems abandoned. > > In the meantime until somebody steps up, I might run my own copy.

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-06 Thread Junio C Hamano
Pratyush Yadav writes: > I'm not too optimistic on finding someone to run this project. I asked > on the list who the maintainer is [0], and no one came up. The repo at > [1] also seems abandoned. In the meantime until somebody steps up, I might run my own copy. I need to allocate a block of ti

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-06 Thread Pratyush Yadav
On 8/6/19 11:52 PM, Junio C Hamano wrote: Pratyush Yadav writes: If there are no comments/objections with this patch, can it be merged please? It usually works the other way around (no comments by default means no interests), but sadly, a larger problem with this area is that there currently

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-06 Thread Junio C Hamano
Pratyush Yadav writes: > If there are no comments/objections with this patch, can it be merged > please? It usually works the other way around (no comments by default means no interests), but sadly, a larger problem with this area is that there currently is nobody who is actively working on main

Re: [PATCH] git-gui: Call do_quit before destroying the main window

2019-08-06 Thread Pratyush Yadav
If there are no comments/objections with this patch, can it be merged please? On 8/4/19 8:09 PM, Pratyush Yadav wrote: If the toplevel window for the window being destroyed is the main window (aka "."), then simply destroying it means the cleanup tasks are not executed like saving the commit me