Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-03 Thread Pratyush Yadav
On 02/09/19 06:23PM, Philip Oakley wrote: > On 02/09/2019 13:25, Pratyush Yadav wrote: > > On 01/09/19 11:27PM, Philip Oakley wrote: > > > Hi Pratyus, [snip] > > > Are there any plans or thoughts about creating a more inclusive > > > man page for > > > the git-gui? > > Having better documentation

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Philip Oakley
On 02/09/2019 13:25, Pratyush Yadav wrote: On 01/09/19 11:27PM, Philip Oakley wrote: Hi Pratyus, On 01/09/2019 12:32, Pratyush Yadav wrote: Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, becau

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Pratyush Yadav
On 01/09/19 11:27PM, Philip Oakley wrote: > Hi Pratyus, > On 01/09/2019 12:32, Pratyush Yadav wrote: > > Hi Birger, > > > > In case you haven't been following the list, Pat has been inactive > > recently, so I am acting as the interim maintainer of git-gui for now, > > because no one else stepped

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Philip Oakley
Hi Pratyus, On 01/09/2019 12:32, Pratyush Yadav wrote: Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, because no one else stepped up and Junio would rather not maintain it. You can find my fork

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
Hello Bert, > But I don't understand this in full. Does this mean pressing CTRL+1 or > +2 does also changes the file selection? Why isn't it sufficient to > just focus the respective file list widget? And than have bindings to > change the selection? > > Bert I don't think it's feasible to focus

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Bert Wesarg
On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote: > > + > > +proc select_first_unstaged_changes_path {} { > > + global ui_workdir > > + select_first_path $ui_workdir > > +} > > + > > +proc select_first_staged_changes_path {} { > > + global ui_index > > + select_first_path $ui_in

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Bert Wesarg
Hi Birger, On Sat, Aug 31, 2019 at 2:23 PM Birger Skogeng Pedersen wrote: > > The user cannot change focus between the list of files, the diff view and > the commit message widgets without using the mouse (clicking either of > the four widgets ). that bugged me two, but never come up with a good

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
Hello Pratyush, (New patch according to our discussion coming up) On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote: > In case you haven't been following the list, Pat has been inactive > recently, so I am acting as the interim maintainer of git-gui for now, > because no one else stepped up

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Junio C Hamano
Pratyush Yadav writes: > ... I am acting as the interim maintainer of git-gui for now, > ... > You can find my fork over at https://github.com/prati0100/git-gui. I am aware of three topics (call-do-quit-before-exit, reload-config and revert-hunks-lines) of your own, plus your 'master' over ther

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Pratyush Yadav
Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, because no one else stepped up and Junio would rather not maintain it. You can find my fork over at https://github.com/prati0100/git-gui. I munge

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-08-31 Thread Birger Skogeng Pedersen
(Finally picking this up again) I've been using this feature for about one year now. If I may say so, I think it is actually really great. It's really helpful for me to be able to use git-gui with just the keyboard, and I'm hoping others will find it useful, too. Let me know what you guys think.