Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-08 Thread Junio C Hamano
Duy Nguyen writes: > I feel lost (and the answer "go read partial clone code!" is perfectly > acceptable) but why would we need to diff trees of two different > repositories? It's just a speculation into far future to open possibilities of what we cannot do right now. There is no *NEED*, just l

Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-08 Thread Duy Nguyen
On Mon, Apr 8, 2019 at 11:06 AM Junio C Hamano wrote: > > Duy Nguyen writes: > > >> Avoid a usage of the_repository by propagating the configured repository > >> to add_if_missing(). Also, prefetch only if the repository being diffed > >> is the_repository (because we do not support lazy fetching

Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-07 Thread Junio C Hamano
Duy Nguyen writes: >> Avoid a usage of the_repository by propagating the configured repository >> to add_if_missing(). Also, prefetch only if the repository being diffed >> is the_repository (because we do not support lazy fetching for any other >> repository anyway). If we are willing to stay l

Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-07 Thread Junio C Hamano
Duy Nguyen writes: >> -static void add_if_missing(struct oid_array *to_fetch, >> +static void add_if_missing(struct oid_array *to_fetch, struct repository *r, > > One last nit. "struct repository *r" is often the first argument. See Yes, and that's easy enough to tweak locally ;-) Thanks.

Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-05 Thread Duy Nguyen
On Sat, Apr 6, 2019 at 12:09 AM Jonathan Tan wrote: > > This is a fixup on the tip of jt/batch-fetch-blobs-in-diff (571debe1d9). > > I don't know if Junio has already merged this branch to next (he marked > this as "Will merge to 'next'" in the "What's Cooking" email, but when I > fetched, it hasn

Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-05 Thread Johannes Schindelin
Hi Jonathan, On Fri, 5 Apr 2019, Jonathan Tan wrote: > This is a fixup on the tip of jt/batch-fetch-blobs-in-diff (571debe1d9). > > I don't know if Junio has already merged this branch to next (he marked > this as "Will merge to 'next'" in the "What's Cooking" email, but when I > fetched, it hasn