Re: [PATCH] diff.c: offer config option to control ws handling in move detection

2018-07-19 Thread Stefan Beller
On Thu, Jul 19, 2018 at 10:32 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > "git format-patch HEAD^ --color" produces red/green output > > (like git log would), so I do not see why --color-moved should impact > > format-patch differently. (i.e. if the user requests format-patch with >

Re: [PATCH] diff.c: offer config option to control ws handling in move detection

2018-07-19 Thread Junio C Hamano
Stefan Beller writes: > "git format-patch HEAD^ --color" produces red/green output > (like git log would), so I do not see why --color-moved should impact > format-patch differently. (i.e. if the user requests format-patch with > color-moved we can do it, otherwise, when colors are off, we do not

Re: [PATCH] diff.c: offer config option to control ws handling in move detection

2018-07-19 Thread Stefan Beller
On Thu, Jul 19, 2018 at 9:29 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > On Wed, Jul 18, 2018 at 10:45 AM Junio C Hamano wrote: > >> > >> Stefan Beller writes: > >> > >> > diff --git a/Documentation/diff-options.txt > >> > b/Documentation/diff-options.txt > >> > index 143acd9417e.

Re: [PATCH] diff.c: offer config option to control ws handling in move detection

2018-07-19 Thread Junio C Hamano
Stefan Beller writes: > On Wed, Jul 18, 2018 at 10:45 AM Junio C Hamano wrote: >> >> Stefan Beller writes: >> >> > diff --git a/Documentation/diff-options.txt >> > b/Documentation/diff-options.txt >> > index 143acd9417e..8da7fed4e22 100644 >> > --- a/Documentation/diff-options.txt >> > +++ b/D

Re: [PATCH] diff.c: offer config option to control ws handling in move detection

2018-07-18 Thread Stefan Beller
On Wed, Jul 18, 2018 at 10:45 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt > > index 143acd9417e..8da7fed4e22 100644 > > --- a/Documentation/diff-options.txt > > +++ b/Documentation/diff-options.txt > > @@ -2

Re: [PATCH] diff.c: offer config option to control ws handling in move detection

2018-07-18 Thread Junio C Hamano
Stefan Beller writes: > diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt > index 143acd9417e..8da7fed4e22 100644 > --- a/Documentation/diff-options.txt > +++ b/Documentation/diff-options.txt > @@ -294,8 +294,11 @@ dimmed_zebra:: > > --color-moved-ws=:: > This