Re: [PATCH] diff: fix lstat() error handling in diff_populate_filespec()

2017-10-27 Thread Junio C Hamano
Junio C Hamano writes: > Andrey Okoshkin writes: > >> I'm not sure why only ENOENT error of lstat() is considered as an >> error but passing by other errno values leads to reading of >> uninitialized 'struct stat st' variable. It means that the >> populated 'diff_filespec' structure may be inco

Re: [PATCH] diff: fix lstat() error handling in diff_populate_filespec()

2017-10-27 Thread Junio C Hamano
Andrey Okoshkin writes: > I'm not sure why only ENOENT error of lstat() is considered as an > error but passing by other errno values leads to reading of > uninitialized 'struct stat st' variable. It means that the > populated 'diff_filespec' structure may be incorrectly filled. Entirely correc