Jeff King writes:
> On Fri, Nov 21, 2014 at 09:48:19AM -0800, Junio C Hamano wrote:
>
>> Michael Haggerty writes:
>>
>> > On 11/21/2014 10:14 AM, Michael Haggerty wrote:
>> >> Couldn't we save ourselves a lot of this "save_errno" boilerplate by
>> >> making error() and warning() preserve errno?
On Fri, Nov 21, 2014 at 09:48:19AM -0800, Junio C Hamano wrote:
> Michael Haggerty writes:
>
> > On 11/21/2014 10:14 AM, Michael Haggerty wrote:
> >> Couldn't we save ourselves a lot of this "save_errno" boilerplate by
> >> making error() and warning() preserve errno? [...]
> >
> > Never mind; I
Michael Haggerty writes:
> On 11/21/2014 10:14 AM, Michael Haggerty wrote:
>> Couldn't we save ourselves a lot of this "save_errno" boilerplate by
>> making error() and warning() preserve errno? [...]
>
> Never mind; I see that Peff already submitted a patch to this effect.
My understanding of t
On 11/21/2014 10:14 AM, Michael Haggerty wrote:
> Couldn't we save ourselves a lot of this "save_errno" boilerplate by
> making error() and warning() preserve errno? [...]
Never mind; I see that Peff already submitted a patch to this effect.
Michael
--
Michael Haggerty
mhag...@alum.mit.edu
--
On 11/17/2014 11:14 PM, Stefan Beller wrote:
> From: Ronnie Sahlberg
>
> Update copy_fd to return a meaningful errno on failure and also
> preserve the existing errno variable.
>
> Signed-off-by: Ronnie Sahlberg
> Signed-off-by: Jonathan Nieder
> Signed-off-by: Stefan Beller
> ---
> As annou
Junio C Hamano writes:
> In short I am not a very big fan of passing around strbuf *err to
> low level helper API functions myself.
>
> But the approach does not make things much worse than it currently
> is, other than code churns to pass an extra pointer around.
Sorry I left the conclusion out
Jonathan Nieder writes:
> Do any callers care about errno? Does the function's API
> documentation say it will make errno meaningful on error, so people
> making changes to copy_fd in the future know to maintain that
> property?
>
> *searches*
>
> Looks like callers are:
>
> convert.c::filter_b
On Mon, Nov 17, 2014 at 4:48 PM, Jonathan Nieder wrote:
> (meta-comment: please snip out the context you are not responding to,
> to make reading easier)
will do
>
> After this patch, setting errno is not part of the contract of
> copy_fd, so the bug Ronnie was fixing is gone.
>
> But it's a li
(meta-comment: please snip out the context you are not responding to,
to make reading easier)
Stefan Beller wrote:
> On Mon, Nov 17, 2014 at 3:35 PM, Jonathan Nieder wrote:
>> Stefan Beller wrote:
>>> Update copy_fd to return a meaningful errno on failure and also
>>> preserve the existing errno
On Mon, Nov 17, 2014 at 3:35 PM, Jonathan Nieder wrote:
> Hi,
>
> Stefan Beller wrote:
>
>> This patch was sent previously to the list as part of
>> that series[2], but it seems to be unrelated to me.
>
> Thanks. Good call.
>
> [...]
>> From: Ronnie Sahlberg
>>
>> Update copy_fd to return a mean
Hi,
Stefan Beller wrote:
> This patch was sent previously to the list as part of
> that series[2], but it seems to be unrelated to me.
Thanks. Good call.
[...]
> From: Ronnie Sahlberg
>
> Update copy_fd to return a meaningful errno on failure and also
> preserve the existing errno variable.
I am reviewing the series and about to resend it with very minor nits
fixed. I just want to point out this fix is orthogonal to the series
and can be picked up no matter how long the reviewing/discussion of
the series goes.
Thanks,
Stefan
On Mon, Nov 17, 2014 at 3:08 PM, Junio C Hamano wrote:
>
Stefan Beller writes:
> This patch was sent previously to the list as part of
> that series[2], but it seems to be unrelated to me.
I am fine to queue obvious and trivial bits first before the larger
main course. For now I'll queue this one and also the series that
has been queued for a while,
13 matches
Mail list logo
