Re: [PATCH] commit-graph: fix memory leak

2019-05-07 Thread Jeff King
On Tue, May 07, 2019 at 11:49:41AM +0200, Ævar Arnfjörð Bjarmason wrote: > I wonder in general if there's a more sustainable solution to these > one-at-a-time memory leak fixes we're doing to these > libraries. E.g. marking some tests in the test suite as passing cleanly > with valgrind's leak che

Re: [PATCH] commit-graph: fix memory leak

2019-05-07 Thread Ævar Arnfjörð Bjarmason
On Mon, May 06 2019, Josh Steadmon wrote: > Free the commit graph when verify_commit_graph_lite() reports an error. > Credit to OSS-Fuzz for finding this leak. > > Signed-off-by: Josh Steadmon > --- > commit-graph.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/co

Re: [PATCH] commit-graph: fix memory leak

2019-05-06 Thread Derrick Stolee
On 5/6/2019 5:58 PM, Emily Shaffer wrote: > Hi, > > This change looks good to me, and like good evidence for the benefits of > automated tooling :) Same here! Keep up the great work here. -Stolee

Re: [PATCH] commit-graph: fix memory leak

2019-05-06 Thread Emily Shaffer
Hi, This change looks good to me, and like good evidence for the benefits of automated tooling :) Thanks! - Emily On Mon, May 06, 2019 at 02:36:58PM -0700, Josh Steadmon wrote: > Free the commit graph when verify_commit_graph_lite() reports an error. > Credit to OSS-Fuzz for finding this leak.