Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-09 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > There was the explicit decision not to fall back to HEAD in 1cfe77333f > ("git-blame: no rev means start from the working tree file.", > 2007-01-30). This change makes sense to me, but perhaps some discussion > or reference to the previous commit is warranted? Y

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 08 2019, SZEDER Gábor wrote: > On Mon, Apr 08, 2019 at 02:44:59PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> On Mon, Apr 08 2019, SZEDER Gábor wrote: >> >> > When 'git blame' is invoked without specifying the commit to start >> > blaming from, it starts from the given file's state i

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-08 Thread SZEDER Gábor
On Mon, Apr 08, 2019 at 02:44:59PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Apr 08 2019, SZEDER Gábor wrote: > > > When 'git blame' is invoked without specifying the commit to start > > blaming from, it starts from the given file's state in the work tree. > > However, when invoked in a b

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 08 2019, SZEDER Gábor wrote: > When 'git blame' is invoked without specifying the commit to start > blaming from, it starts from the given file's state in the work tree. > However, when invoked in a bare repository without a start commit, > then there is no work tree state to start f

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-07 Thread Eric Sunshine
On Sun, Apr 7, 2019 at 7:43 PM SZEDER Gábor wrote: > [...] > We could improve the error message, of course, but let's just default > to HEAD in a bare repository instead, as most likely that is what the > user wanted anyway (if they wanted to start from an other commit, then > they would have spec