Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Duy Nguyen
On Tue, Jan 8, 2013 at 3:07 PM, Stefan Beller wrote: > --- > builtin/clone.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/builtin/clone.c b/builtin/clone.c > index ec2f75b..5e91c1e 100644 > --- a/builtin/clone.c > +++ b/builtin/clone.c > @@ -818,6 +818,9 @@ int cmd_clone(int argc,

Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Jonathan Nieder
Stefan Beller wrote: > I am struggling a little with the development process, > is a sign-off strictly required for git as it is for kernel development? Yes. Documentation/SubmittingPatches has more hints. > Signed-off-by: Stefan Beller > > This adds a warning and the previous patch adds the d

Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Jonathan Nieder
Stefan Beller wrote: > --- a/builtin/clone.c > +++ b/builtin/clone.c > @@ -818,6 +818,9 @@ int cmd_clone(int argc, const char **argv, const char > *prefix) > remote = remote_get(option_origin); > transport = transport_get(remote, remote->url[0]); > > + if (option_depth && transp

Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Stefan Beller
Hi, I am struggling a little with the development process, is a sign-off strictly required for git as it is for kernel development? If so here would be my sign-off: Signed-off-by: Stefan Beller This adds a warning and the previous patch adds the documentation. However I agree to Junio, that th