Re: [PATCH] Uses git-credential for git-imap-send

2014-04-29 Thread Junio C Hamano
Jeff King writes: > On Mon, Apr 28, 2014 at 08:00:04PM -0700, Dan Albert wrote: > >> > I noticed that we are just filling in the password here, since we'll >> > always fill cred.username from srvc->user. The lines directly above are: >> > >> > if (!srvc->user) { >> > fpri

Re: [PATCH] Uses git-credential for git-imap-send

2014-04-28 Thread Jeff King
On Mon, Apr 28, 2014 at 08:00:04PM -0700, Dan Albert wrote: > > I noticed that we are just filling in the password here, since we'll > > always fill cred.username from srvc->user. The lines directly above are: > > > > if (!srvc->user) { > > fprintf(stderr, "Skipping server

Re: [PATCH] Uses git-credential for git-imap-send

2014-04-28 Thread Jeff King
On Sun, Apr 27, 2014 at 10:58:51AM -0700, Dan Albert wrote: > git-imap-send was directly prompting for a password rather than using > git-credential. git-send-email, on the other hand, supports git-credential. > > This is a necessary improvement for users that use two factor authentication, > as

Re: [PATCH] Uses git-credential for git-imap-send

2014-04-27 Thread Jeff King
On Sat, Apr 26, 2014 at 11:30:11AM -0700, Dan Albert wrote: > I had resent a less broken patch after I noticed the tabs, but it seems to > have gotten lost. Better formatted patch at the bottom of this message. Your emails (including this one) are multipart/alternatives with an html part, which w

Re: [PATCH] Uses git-credential for git-imap-send

2014-04-26 Thread Jeff King
On Sat, Apr 26, 2014 at 10:50:26AM -0700, Dan Albert wrote: > git-imap-send was directly prompting for a password rather than using > git-credential. git-send-email, on the other hand, supports > git-credential. Yay. These sorts of conversions were definitely on my mind when I did the original cr