Re: [PATCH] SQUASH

On Mon, Aug 12, 2019 at 5:14 AM René Scharfe wrote: > > That looks like an issue worth its own commit. OK, but then will make my topic interesting; indeed it almost feels like it should be 3 different topics all depending of each other in a chain: * really use the match context * move to xmalloc

Re: [PATCH] SQUASH

Am 12.08.19 um 09:35 schrieb Carlo Arenas: > On Sat, Aug 10, 2019 at 12:48 PM René Scharfe wrote: >>> On Sat, Aug 10, 2019 at 12:57 AM René Scharfe wrote: >>> >>> Do you mind then if I "adopt" your patch and submit a reroll with it, >> >> I don't mind, sounds good. > > I had to squash another fix

Re: [PATCH] SQUASH

On Sat, Aug 10, 2019 at 12:48 PM René Scharfe wrote: > > On Sat, Aug 10, 2019 at 12:57 AM René Scharfe wrote: > > > > Do you mind then if I "adopt" your patch and submit a reroll with it, > > I don't mind, sounds good. I had to squash another fix that was reported[1] before but wasn't picked up

Re: [PATCH] SQUASH

Am 10.08.19 um 10:42 schrieb Carlo Arenas: > On Sat, Aug 10, 2019 at 12:57 AM René Scharfe wrote: >> >> Am 10.08.19 um 05:03 schrieb Carlo Marcelo Arenas Belón: >>> Make using a general context (that is only needed with NED) to depend >>> on NED being selected at compile time. >> >> A custom gener

Re: [PATCH] SQUASH

Hi Carlo, On Fri, 9 Aug 2019, Carlo Marcelo Arenas Belón wrote: > diff --git a/grep.c b/grep.c > index 8255ec956e..233072ed80 100644 > --- a/grep.c > +++ b/grep.c > @@ -482,6 +482,7 @@ static void free_pcre1_regexp(struct grep_pat *p) > #endif /* !USE_LIBPCRE1 */ > > #ifdef USE_LIBPCRE2 > +#ifd

Re: [PATCH] SQUASH

On Sat, Aug 10, 2019 at 12:57 AM René Scharfe wrote: > > Am 10.08.19 um 05:03 schrieb Carlo Marcelo Arenas Belón: > > Make using a general context (that is only needed with NED) to depend > > on NED being selected at compile time. > > A custom general context is needed to convince PCRE2 to use xma

Re: [PATCH] SQUASH

Am 10.08.19 um 05:03 schrieb Carlo Marcelo Arenas Belón: > Make using a general context (that is only needed with NED) to depend > on NED being selected at compile time. A custom general context is needed to convince PCRE2 to use xmalloc() instead of mallo(). That is independent of the choice of

Re: [PATCH] squash! completion: fill COMPREPLY directly when completing refs

SZEDER Gábor writes: > On Fri, Feb 10, 2017 at 10:44 PM, Junio C Hamano wrote: > >> Should I expect a reroll to come, or is this the only fix-up to the >> series that begins at <20170203025405.8242-1-szeder@gmail.com>? >> >> No hurries. > > Yes, definitely. > > I found a minor bug in the mid

Re: [PATCH] squash! completion: fill COMPREPLY directly when completing refs

On Fri, Feb 10, 2017 at 10:44 PM, Junio C Hamano wrote: > Should I expect a reroll to come, or is this the only fix-up to the > series that begins at <20170203025405.8242-1-szeder@gmail.com>? > > No hurries. Yes, definitely. I found a minor bug in the middle of the series, and haven't quite

Re: [PATCH] squash! completion: fill COMPREPLY directly when completing refs

SZEDER Gábor writes: > Care should be taken, though, because that prefix might contain > 'for-each-ref' format specifiers as part of the left hand side of a > '..' range or '...' symmetric difference notation or fetch/push/etc. > refspec, e.g. 'git log "evil-%(refname)..br'. Doubling every '%' >

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Hi Junio, On Mon, 15 Aug 2016, Junio C Hamano wrote: > Obviously (1) is a lot of impact with little gain, and as Jacob > already offered to do, I think (2) is a lot more sensible solution > and it also is more in line with your "If it isn't broken, do not > fix it", I would say. Yep, that makes

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Johannes Schindelin writes: > On Sun, 14 Aug 2016, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > - test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g') >> > + test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g' -e 'y/>/_/') >> ... > I know that this is so because my first iteration of th

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Hi Junio, On Sun, 14 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > - test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g') > > + test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g' -e 'y/>/_/') > > The existing sed scriptlet says "we cannot have slash and do not > want to have spa

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Johannes Schindelin writes: > - test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g') > + test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g' -e 'y/>/_/') The existing sed scriptlet says "we cannot have slash and do not want to have space in filename, so we squash runs of them to a single underscore"

Re: [PATCH] squash! bash-completion: add support for git-log --merges= and log.merges

Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html