Re: [PATCH] Rewrite the diff-no-index.c

2014-03-17 Thread Matthieu Moy
- Original Message - > Thank you for your comments.If I rename some function when I work on a large > project like git,whether it will cause other error that I can not solve .So > I use the ugly way for this reason. (please, don't top-post on this list). The read_directory to be renamed i

Re: [PATCH] Rewrite the diff-no-index.c

2014-03-17 Thread Eric Sunshine
Thanks for the resubmission. Comments below... On Sun, Mar 16, 2014 at 8:44 AM, wrote: > From: 沈承恩 > Subject: [PATCH] Rewrite the diff-no-index.c This is your second version of the patch, so you should say [PATCH v2]. Most patches rewrite something, so "rewrite" in the subject does not convey