Re: [PATCH] Define constants for lengths of object names

2014-05-02 Thread brian m. carlson
On Fri, May 02, 2014 at 07:15:44AM +0700, Duy Nguyen wrote: > On Fri, May 2, 2014 at 6:05 AM, Jonathan Nieder wrote: > > > > I can make up for it in enthuasiasm. Please? It's something I've > > wanted for a long time but never found the time to do. > > It's definitely better in the sense that t

Re: [PATCH] Define constants for lengths of object names

2014-05-01 Thread Duy Nguyen
On Fri, May 2, 2014 at 6:05 AM, Jonathan Nieder wrote: > brian m. carlson wrote: >> On Thu, May 01, 2014 at 10:20:07AM -0700, Jonathan Nieder wrote: > >>> What happened to the >>> >>> struct object_id { >>> unsigned char id[20]; >>> }; >>> >>> ... >>> >>> struct ob

Re: [PATCH] Define constants for lengths of object names

2014-05-01 Thread Jonathan Nieder
brian m. carlson wrote: > On Thu, May 01, 2014 at 10:20:07AM -0700, Jonathan Nieder wrote: >> What happened to the >> >> struct object_id { >> unsigned char id[20]; >> }; >> >> ... >> >> struct object { >> ... >> struct object_id id; >>

Re: [PATCH] Define constants for lengths of object names

2014-05-01 Thread brian m. carlson
On Thu, May 01, 2014 at 10:20:07AM -0700, Jonathan Nieder wrote: > Hi, > > brian m. carlson wrote: > > > --- a/object.h > > +++ b/object.h > [...] > > @@ -49,7 +56,7 @@ struct object { > > unsigned used : 1; > > unsigned type : TYPE_BITS; > > unsigned flags : FLAG_BITS; > > - unsign

Re: [PATCH] Define constants for lengths of object names

2014-05-01 Thread Jonathan Nieder
Jonathan Nieder wrote: > brian m. carlson wrote: >> --- a/object.h >> +++ b/object.h > [...] >> @@ -49,7 +56,7 @@ struct object { >> unsigned used : 1; >> unsigned type : TYPE_BITS; >> unsigned flags : FLAG_BITS; >> -unsigned char sha1[20]; >> +unsigned char sha1[GIT_OID_RAW

Re: [PATCH] Define constants for lengths of object names

2014-05-01 Thread Jonathan Nieder
Hi, brian m. carlson wrote: > --- a/object.h > +++ b/object.h [...] > @@ -49,7 +56,7 @@ struct object { > unsigned used : 1; > unsigned type : TYPE_BITS; > unsigned flags : FLAG_BITS; > - unsigned char sha1[20]; > + unsigned char sha1[GIT_OID_RAWSZ]; Maybe my brain has