On Mon, 2016-04-18 at 11:35 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > The local variable 'options' was shadowing a global of the same
> > name.
> >
> > Signed-off-by: David Turner
> > ---
>
> OK. In general, giving a longer and more descriptive name to the
> global would be a
David Turner writes:
> The local variable 'options' was shadowing a global of the same name.
>
> Signed-off-by: David Turner
> ---
OK. In general, giving a longer and more descriptive name to the
global would be a direction to lead to more readable code, though.
> remote-curl.c | 18
2 matches
Mail list logo
