Re: [GSoC][PATCH v6] parse-options: do not show usage upon invalid option value

2018-03-22 Thread Paul-Sebastian Ungureanu
Hi, Thank you a lot for your advice! I will keep in mind your words next time I will send a patch. Best regards, Paul Ungurenanu

Re: [GSoC][PATCH v6] parse-options: do not show usage upon invalid option value

2018-03-21 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > diff --git a/t/t0041-usage.sh b/t/t0041-usage.sh > new file mode 100755 > index 0..ac96bc3b9 > --- /dev/null > +++ b/t/t0041-usage.sh > @@ -0,0 +1,107 @@ > +#!/bin/sh > + > +test_description='Test commands behavior when given invalid argument value' > +

Re: [GSoC][PATCH v6] parse-options: do not show usage upon invalid option value

2018-03-20 Thread Eric Sunshine
On Tue, Mar 20, 2018 at 1:50 PM, Paul-Sebastian Ungureanu wrote: > Usually, the usage should be shown only if the user does not know what > options are available. If the user specifies an invalid value, the user > is already aware of the available options. In this case, there is no > point in disp