Re: [GSoC][PATCH 2/3] cherry-pick/revert: add --skip option

2019-06-10 Thread Phillip Wood
Hi Rohit On 10/06/2019 14:43, Rohit Ashiwal wrote: > Hi Phillip > > On 2019-06-10 10:40 UTC Phillip Wood wrote: >> >> [...] >> It's actually a bit more complicated as if the cherry-pick failed >> because it would have overwriten untracked files then CHERRY_PICK_HEAD >> will not exist but we want

Re: [GSoC][PATCH 2/3] cherry-pick/revert: add --skip option

2019-06-10 Thread Rohit Ashiwal
Hi Phillip On 2019-06-10 10:40 UTC Phillip Wood wrote: > > [...] > It's actually a bit more complicated as if the cherry-pick failed > because it would have overwriten untracked files then CHERRY_PICK_HEAD > will not exist but we want to be able to skip that pick. So it should > not error out in

Re: [GSoC][PATCH 2/3] cherry-pick/revert: add --skip option

2019-06-10 Thread Phillip Wood
Hi Rohit On 10/06/2019 06:57, Rohit Ashiwal wrote: > Hey Phillip > > On Sun, 9 Jun 2019 19:01:35 +0100 Phillip Wood > wrote: >> >> Hi Rohit >> >> --skip is definitely a useful addition to cherry-pick/revert >> >> On 08/06/2019 20:19, Rohit Ashiwal wrote: >>> >>> [...] >>> @@ -2784,6 +2784,29 @@

Re: [GSoC][PATCH 2/3] cherry-pick/revert: add --skip option

2019-06-09 Thread Rohit Ashiwal
Hey Phillip On Sun, 9 Jun 2019 19:01:35 +0100 Phillip Wood wrote: > > Hi Rohit > > --skip is definitely a useful addition to cherry-pick/revert > > On 08/06/2019 20:19, Rohit Ashiwal wrote: > > > > [...] > > @@ -2784,6 +2784,29 @@ int sequencer_rollback(struct repository *r, struct > > replay

Re: [GSoC][PATCH 2/3] cherry-pick/revert: add --skip option

2019-06-09 Thread Phillip Wood
Hi Rohit --skip is definitely a useful addition to cherry-pick/revert On 08/06/2019 20:19, Rohit Ashiwal wrote: > git am or rebase advise the user to use `git (am | rebase) --skip` to > skip the commit. cherry-pick and revert also have this concept of > skipping commits but they advise the user t

Re: [GSoC][PATCH 2/3] cherry-pick/revert: add --skip option

2019-06-09 Thread Thomas Gummerer
On 06/09, Rohit Ashiwal wrote: > git am or rebase advise the user to use `git (am | rebase) --skip` to > skip the commit. cherry-pick and revert also have this concept of > skipping commits but they advise the user to use `git reset` (or in > case of a patch which had conflicts, `git reset --merge`