Re: Re* [PATCH] git-remote-testgit: avoid process substitution

2013-04-29 Thread Junio C Hamano
Johannes Sixt writes: > The patch below doesn't remove the bash dependency, yet, but it addresses > the problematic mismatch you noticed without the need for $LF. Can you > please queue it to move the topic forward? I'll send three-patch series I have (including the two discussed in the thread)

Re: Re* [PATCH] git-remote-testgit: avoid process substitution

2013-04-27 Thread Johannes Sixt
Am 27.04.2013 01:26, schrieb Junio C Hamano: > Felipe Contreras writes: > >> No, it wouldn't, but I don't think there's any way to do \<\> or \b in globs. > > This should do in the meantime, but it further needs: > > - J6t's sign off for the follow-up part to remove remaining >bash-isms to

Re* [PATCH] git-remote-testgit: avoid process substitution

2013-04-26 Thread Junio C Hamano
Felipe Contreras writes: > No, it wouldn't, but I don't think there's any way to do \<\> or \b in globs. This should do in the meantime, but it further needs: - J6t's sign off for the follow-up part to remove remaining bash-isms to complete this patch (the last part of the patch is from

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-26 Thread Felipe Contreras
On Fri, Apr 26, 2013 at 5:25 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Thu, Apr 25, 2013 at 12:56 AM, Johannes Sixt wrote: >>> From: Johannes Sixt >>> >>> Bash on Windows does not implement process substitution. >> >> Nevermind, reporting all the refs creates a lot of irrelev

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-26 Thread Junio C Hamano
Felipe Contreras writes: > On Thu, Apr 25, 2013 at 12:56 AM, Johannes Sixt wrote: >> From: Johannes Sixt >> >> Bash on Windows does not implement process substitution. > > Nevermind, reporting all the refs creates a lot of irrelevant output, > this version is fine. When $before has this in it:

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-26 Thread Felipe Contreras
On Thu, Apr 25, 2013 at 12:56 AM, Johannes Sixt wrote: > From: Johannes Sixt > > Bash on Windows does not implement process substitution. Nevermind, reporting all the refs creates a lot of irrelevant output, this version is fine. Acknowledged-by: Felipe Contreras -- Felipe Contreras -- To un

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-25 Thread Felipe Contreras
On Thu, Apr 25, 2013 at 3:06 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Thu, Apr 25, 2013 at 1:25 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: >>> >> ... >> + git for-each-ref --format='%(refname) %(objectname)' | >> + while read r

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-25 Thread Junio C Hamano
Felipe Contreras writes: > On Thu, Apr 25, 2013 at 1:25 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> > ... > + git for-each-ref --format='%(refname) %(objectname)' | > + while read ref a > do > - test $a =

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-25 Thread Felipe Contreras
On Thu, Apr 25, 2013 at 1:25 PM, Junio C Hamano wrote: > Felipe Contreras writes: > ... + git for-each-ref --format='%(refname) %(objectname)' | + while read ref a do - test $a == $b && continue +

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-25 Thread Junio C Hamano
Felipe Contreras writes: >>> ... >>> + git for-each-ref --format='%(refname) %(objectname)' | >>> + while read ref a >>> do >>> - test $a == $b && continue >>> + case "$before" in >>> + *"$ref $a"*)

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-25 Thread Felipe Contreras
On Thu, Apr 25, 2013 at 9:57 AM, Junio C Hamano wrote: > Johannes Sixt writes: > >> From: Johannes Sixt >> >> Bash on Windows does not implement process substitution. >> >> Signed-off-by: Johannes Sixt >> --- >> ... >> Here is a fix. It assumes that the list of refs after the import is >> a sup

Re: [PATCH] git-remote-testgit: avoid process substitution

2013-04-25 Thread Junio C Hamano
Johannes Sixt writes: > From: Johannes Sixt > > Bash on Windows does not implement process substitution. > > Signed-off-by: Johannes Sixt > --- > ... > Here is a fix. It assumes that the list of refs after the import is > a superset of the refs before the import. (Can refs be deleted > via fast