RE: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread David Turner
> -Original Message- > From: Stefan Beller [mailto:sbel...@google.com] > Sent: Friday, December 02, 2016 7:30 PM > To: bmw...@google.com; David Turner > Cc: git@vger.kernel.org; sand...@crustytoothpaste.net; hvo...@hvoigt.net; > gits...@pobox.com; Stefan Beller > Subject: [RFC PATCHv2 15/17

Re: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread Brandon Williams
On 12/05, Stefan Beller wrote: > On Mon, Dec 5, 2016 at 11:25 AM, Brandon Williams wrote: > > On 12/02, Stefan Beller wrote: > >> > >> test_expect_success '"checkout " honors diff.ignoreSubmodules' > >> ' > >> @@ -63,6 +70,260 @@ test_expect_success '"checkout " honors > >> submodule.*.ignore f

Re: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread Stefan Beller
On Mon, Dec 5, 2016 at 11:25 AM, Brandon Williams wrote: > On 12/02, Stefan Beller wrote: >> >> test_expect_success '"checkout " honors diff.ignoreSubmodules' ' >> @@ -63,6 +70,260 @@ test_expect_success '"checkout " honors >> submodule.*.ignore from .git/ >> ! test -s actual >> ' > > Sho

Re: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread Brandon Williams
On 12/02, Stefan Beller wrote: > > test_expect_success '"checkout " honors diff.ignoreSubmodules' ' > @@ -63,6 +70,260 @@ test_expect_success '"checkout " honors > submodule.*.ignore from .git/ > ! test -s actual > ' Should you use test_must_fail and not '!'? -- Brandon Williams