Re: [PATCH 1/7] remote-hg: don't decode UTF-8 paths into Unicode objects

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 12:30 PM, Richard Hansen wrote: > On 2013-11-11 06:04, Felipe Contreras wrote: >> Richard Hansen wrote: >>> The internal mercurial API expects ordinary 8-bit string objects, not >>> Unicode string objects. With this change, the test-hg.sh unit tests >>> pass again. >> >> T

Re: [PATCH 1/7] remote-hg: don't decode UTF-8 paths into Unicode objects

2013-11-11 Thread Richard Hansen
On 2013-11-11 06:04, Felipe Contreras wrote: > Richard Hansen wrote: >> The internal mercurial API expects ordinary 8-bit string objects, not >> Unicode string objects. With this change, the test-hg.sh unit tests >> pass again. > > This makes sense to me, but the tests are already passing for me.

RE: [PATCH 1/7] remote-hg: don't decode UTF-8 paths into Unicode objects

2013-11-11 Thread Felipe Contreras
Richard Hansen wrote: > The internal mercurial API expects ordinary 8-bit string objects, not > Unicode string objects. With this change, the test-hg.sh unit tests > pass again. This makes sense to me, but the tests are already passing for me. How are they failing for you? -- Felipe Contreras -