Re: [PATCH] Prefer sysconf(_SC_OPEN_MAX) over getrlimit(RLIMIT_NOFILE,...)

2012-08-22 Thread Junio C Hamano
"Joachim Schmitz" writes: >> Looks sane but it would be more readable to make this a small helper > function, >> so that we do not need to have #ifdef/#endif in the primary flow of the > code. > > Hmm, in compat/? Worth the effort fort hat single occrence? Compat/ is to have some systems that la

RE: [PATCH] Prefer sysconf(_SC_OPEN_MAX) over getrlimit(RLIMIT_NOFILE,...)

2012-08-22 Thread Joachim Schmitz
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de] > Sent: Wednesday, August 22, 2012 7:53 PM > To: 'Junio C Hamano' > Cc: 'git@vger.kernel.org' > Subject: RE: [PATCH] Prefer sysconf(_SC_OPEN_MAX) over > getrlimit(RLIMIT_NOFILE,...) > > >

RE: [PATCH] Prefer sysconf(_SC_OPEN_MAX) over getrlimit(RLIMIT_NOFILE,...)

2012-08-22 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Wednesday, August 22, 2012 7:23 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] Prefer sysconf(_SC_OPEN_MAX) over > getrlimit(RLIMIT_NOFILE,...) > > "Joachim Schmitz" writes: >

Re: [PATCH] Prefer sysconf(_SC_OPEN_MAX) over getrlimit(RLIMIT_NOFILE,...)

2012-08-22 Thread Junio C Hamano
"Joachim Schmitz" writes: > Signed-off-by: Joachim Schmitz > --- > sha1_file.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/sha1_file.c b/sha1_file.c > index af5cfbd..76714ad 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -747,6 +747,9 @@ static int open_packed_git_1(struct