On 2019-09-12 at 16:47:41 +0200, Eric Sunshine wrote:
> On Thu, Sep 12, 2019 at 7:59 AM Tobias Klauser wrote:
> > In some cases, the svn author names might contain leading or trailing
> > whitespaces, leading to messages such as:
> >
> > Author: user1
> >not defined in authors.txt
> >
> > (
On Thu, Sep 12, 2019 at 7:59 AM Tobias Klauser wrote:
> In some cases, the svn author names might contain leading or trailing
> whitespaces, leading to messages such as:
>
> Author: user1
>not defined in authors.txt
>
> (the trailing newline leads to the line break). The user "user1" is
> de
Eric Wong writes:
> Ævar Arnfjörð Bjarmason wrote:
>> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the
>> original report.
>
> Thanks for taking a look at this. Also https://bugs.debian.org/894997
>
>> --- a/perl/Git.pm
>> +++ b/perl/Git.pm
>> @@ -554,7 +554,7 @@ sub get_rec
On Fri, Apr 06, 2018 at 01:15:14PM +, Ævar Arnfjörð Bjarmason wrote:
> Change code in Git.pm that sometimes calls chomp() on undef to only do
> so the value is defined.
>
> This code has been chomping undef values ever since it was added in
> b26098fc2f ("git-svn: reduce scope of input record
On Fri, Apr 06 2018, Eric Wong wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> On Fri, Apr 06 2018, Eric Wong wrote:
>> > Ævar Arnfjörð Bjarmason wrote:
>> >
>> >> --- a/perl/Git.pm
>> >> +++ b/perl/Git.pm
>> >> @@ -554,7 +554,7 @@ sub get_record {
>> >> my ($fh, $rs) = @_;
>> >> local $/ = $rs;
Ævar Arnfjörð Bjarmason wrote:
> On Fri, Apr 06 2018, Eric Wong wrote:
> > Ævar Arnfjörð Bjarmason wrote:
> >
> >> --- a/perl/Git.pm
> >> +++ b/perl/Git.pm
> >> @@ -554,7 +554,7 @@ sub get_record {
> >>my ($fh, $rs) = @_;
> >>local $/ = $rs;
> >>my $rec = <$fh>;
> >> - chomp $rec if
On Fri, Apr 06 2018, Eric Wong wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the
>> original report.
>
> Thanks for taking a look at this. Also https://bugs.debian.org/894997
>
>> --- a/perl/Git.pm
>> +++ b/perl/Git.pm
>> @@ -554,7 +
Ævar Arnfjörð Bjarmason wrote:
> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the
> original report.
Thanks for taking a look at this. Also https://bugs.debian.org/894997
> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -554,7 +554,7 @@ sub get_record {
> my ($fh, $rs) = @
Hi Ævar,
On Fri, 6 Apr 2018, Ævar Arnfjörð Bjarmason wrote:
> Change code in Git.pm that sometimes calls chomp() on undef to only do
> so the value is defined.
>
> This code has been chomping undef values ever since it was added in
> b26098fc2f ("git-svn: reduce scope of input record separator c
Eric Wong writes:
> Todd Zullinger wrote:
>> I'm running the tests with and without your patch as well.
>> So far I've run t9128 300 times with the patch and no
>> failures. Without it, it's failed 3 times in only a few
>> dozen runs. That's promising.
>
> Thanks for confirming it works on oth
"Bennett, Brian" writes:
> Thank you all for your guidance,
>
> I have completed my test this morning with the patch and the 'git
> svn dcommit' is now SUCCESSFUl!
Thanks, all.
odd
Zullinger
Sent: Thursday, December 14, 2017 5:50 PM
To: Bennett, Brian
Cc: Eric Wong ; Junio C Hamano ;
git@vger.kernel.org
Subject: Re: [PATCH] git-svn: convert CRLF to LF in commit message to SVN
Hi Brian,
Bennett, Brian wrote:
> Thank you for your fast response,
>
> I haven
Hi Brian,
Bennett, Brian wrote:
> Thank you for your fast response,
>
> I haven't done a build of this type before (so I could
> test the patch first) so I'm trying to do that and get
> this far:
...
> I don't want to drag out testing the patch, so if either
> of you are able to quickly guide me
Thank you for your fast response,
I haven't done a build of this type before (so I could test the patch first) so
I'm trying to do that and get this far:
1. git clone https://github.com/msysgit/msysgit.git "c:\temp\git\guitbuild"
2. git clone https://github.com/git-for-windows/git.git
"c:\temp\g
Junio C Hamano writes:
> > Yep, seems alright. Can you apply directly?
> > Been a bit preoccupied as of late. Thanks.
>
> Surely, I'll just add your Reviewed-by: myself ;-)
OK, thanks. This will fix the bug I've reported here a week or so ago
(see the References header).
urs
Eric Wong writes:
> Junio C Hamano wrote:
>> Urs Thuermann writes:
>>
>> > In parse_svn_date() prepend the correct UTC offset to the timestamp
>> > returned. This is the offset in effect at the commit time instead of
>> > the offset in effect at calling time.
>> >
>> > Signed-off-by: Urs Thue
Junio C Hamano wrote:
> Urs Thuermann writes:
>
> > In parse_svn_date() prepend the correct UTC offset to the timestamp
> > returned. This is the offset in effect at the commit time instead of
> > the offset in effect at calling time.
> >
> > Signed-off-by: Urs Thuermann
> > ---
> > perl/Git/
Urs Thuermann writes:
> In parse_svn_date() prepend the correct UTC offset to the timestamp
> returned. This is the offset in effect at the commit time instead of
> the offset in effect at calling time.
>
> Signed-off-by: Urs Thuermann
> ---
> perl/Git/SVN.pm | 2 +-
> 1 file changed, 1 insert
Thanks.
Andreas Heiduk wrote:
> Some options specific for `git svn commit-diff` where not documented
> so far.
>
> Signed-off-by: Andreas Heiduk
Thanks again. It's been a while since "commit-diff" :)
Signed-off and pushed for Junio:
The following changes since commit 02a2850ad58eff6de70eb2dc5f9634
Hiroshi Shirosaki wrote:
> I have the following authentication failure while svn rebase and
> svn dcommit works fine without authentication failures.
>
> $ git svn branch v7_3
> Copying https://xxx at r27519
> to https:///v7_
Eric Wong writes:
> Junio: ping?
>
> https://public-inbox.org/git/20161223014202.GA8327@starla/raw
>
> Thanks.
Thanks for reminding. This indeed fell thru cracks.
Junio: ping?
https://public-inbox.org/git/20161223014202.GA8327@starla/raw
Thanks.
On 2016-12-23 02:42, Eric Wong wrote:
> Hi Michael, the patch below should fix things up.
Thank you Eric, I was able to successfully fetch the SVN tag with your
patch applied.
Cheers,
--
Michael Fladischer
Fladi.at
signature.asc
Description: OpenPGP digital signature
Eric Wong writes:
> Blindly checking a path component for falsiness is unwise, as
> "0" is false to Perl, but a valid pathname component for SVN
> (or any filesystem).
>
> Found via random code reading.
>
> Signed-off-by: Eric Wong
> ---
> Junio: this bugfix should go to "maint".
> Will push
Junio C Hamano wrote:
> Just peeking from the sideline, but the your squash looks like an
> improvement to me.
Thanks.
> Hopefully the final version after your interaction with Dscho can
> come to me via another "pull this now"?
Not sure if I'll be online the next few days,
but I've preeptively
Eric Wong writes:
> Johannes Schindelin wrote:
>> +++ b/perl/Git/SVN.pm
>> @@ -1658,6 +1658,11 @@ sub tie_for_persistent_memoization {
>> if ($memo_backend > 0) {
>> tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml";
>> } else {
>> +# first verify that any
Johannes Schindelin wrote:
> +++ b/perl/Git/SVN.pm
> @@ -1658,6 +1658,11 @@ sub tie_for_persistent_memoization {
> if ($memo_backend > 0) {
> tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml";
> } else {
> + # first verify that any existing file can actual
Junio C Hamano wrote:
> Subject: [PATCH] t9100: portability fix
>
> Do not say "export VAR=VAL"; "VAR=VAL && export VAR" is always more
> portable.
Oops, sorry I should've caught that :x
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.
Junio C Hamano writes:
> Eric Wong writes:
>
>> Repushed my master in case it's a convenient time to pull.
>>
>> The following changes since commit 29493589e97a2de0c4c1c314f61ccafaee3b5caf:
>>
>> archive-tar: huge offset and future timestamps would not work on 32-bit
>> (2016-07-15 10:51:55 -
Eric Wong writes:
> Repushed my master in case it's a convenient time to pull.
>
> The following changes since commit 29493589e97a2de0c4c1c314f61ccafaee3b5caf:
>
> archive-tar: huge offset and future timestamps would not work on 32-bit
> (2016-07-15 10:51:55 -0700)
>
> are available in the git
Eric Wong writes:
> Christopher Layne wrote:
>> * cmd_clone should detect a missing $url arg before using it otherwise
>> an uninitialized value error is emitted in even the simplest case of
>> 'git svn clone' without arguments.
>
> Thanks, this patch looks obviously correct.
>
> I've elimin
> On Jul 2, 2016, at 2315 PT, Eric Wong wrote:
>> sub cmd_clone {
>> my ($url, $path) = @_;
>> -if (!defined $path &&
>> +if (!$url) {
>> +die "SVN repository location required ",
>> +"as a command-line argument\n";
>
> "as a command-line argument" seems
Christopher Layne wrote:
> * cmd_clone should detect a missing $url arg before using it otherwise
> an uninitialized value error is emitted in even the simplest case of
> 'git svn clone' without arguments.
Thanks, this patch looks obviously correct.
I've eliminated the '* ' and space prefix
Christian Couder wrote:
> Signed-off-by: Christian Couder
Thanks Christian,
Signed-off-by: Eric Wong
...And pushed to my svn/bad-ref branch for Junio.
(I don't think I'll have other git-svn-related changes
immediately pending)
The following changes since commit 63a35025b11bf0e7ef39693aeea3b6
Eric Wong writes:
> Junio C Hamano wrote:
>> I am not sure if it is a good idea to show */*/* as an example in
>> the message (that is an anti-example of 'one set of wildcard' by
>> having three stars, isn't it?), but that is not a new issue this
>> change introduces.
>
> Actually, going back to
Junio C Hamano wrote:
> I am not sure if it is a good idea to show */*/* as an example in
> the message (that is an anti-example of 'one set of wildcard' by
> having three stars, isn't it?), but that is not a new issue this
> change introduces.
Actually, going back to commit 570d35c26dfbc40757da6
Hello all,
On 01/14/2016 09:15 PM, Junio C Hamano wrote:
> Eric Wong writes:
>
>> Error messages should attempt to fit within the confines of
>> an 80-column terminal to avoid compatibility and accessibility
>> problems. Furthermore the word "directories" can be misleading
>> when used in the co
Dair Grant wrote:
> This takes 10 minutes to process when using a single hash, vs
> 3 seconds with a hash of hashes.
>
> Signed-off-by: Dair Grant
Thanks! I've made some minor edits, will push the following out
to git://bogomips.org/git-svn.git for Junio to pull in a day
or so.
Btw, feel free
ds,
Victor
From: Eric Wong [normalper...@yhbt.net]
Sent: Wednesday, September 23, 2015 12:22 PM
To: Victor Leschuk
Cc: Junio C Hamano; git@vger.kernel.org
Subject: Re: [PATCH] git-svn: make batch mode optional for git-cat-file
Victor Leschuk wrote:
> Hello Eric, thank
Victor Leschuk wrote:
> Hello Eric, thanks for looking into it.
>
> >> git-cat-file has outgrown the parent perl process several times
> >> (git-cat-file - ~3-4Gb, perl - 400Mb).
>
> > Ugh, that sucks.
> > Even the 400Mb size of Perl annoys me greatly and I'd work
> > on fixing it if I had more
ide
git-cat-file, I think we could give it a try, I can prepare a patch and run
some tests.
--
Best Regards,
Victor
From: Eric Wong [normalper...@yhbt.net]
Sent: Tuesday, September 22, 2015 5:35 PM
To: Victor Leschuk
Cc: Junio C Hamano; git@vger.kernel.org
Subject: Re: [PATCH] git-svn: ma
Eric Wong wrote:
> Victor Leschuk wrote:
> > The thing is that git-cat-file keeps growing during work when running
> > in "batch" mode. See the figure attached: it is for cloning a rather
> > small repo (1 hour to clone about ~14000 revisions). However the clone
> > of a large repo (~28 revis
Victor Leschuk wrote:
> The thing is that git-cat-file keeps growing during work when running
> in "batch" mode. See the figure attached: it is for cloning a rather
> small repo (1 hour to clone about ~14000 revisions). However the clone
> of a large repo (~28 revisions) took about 2 weeks and
Victor Leschuk writes:
> We already do have some of these: 'no-metadata', 'no-checkout',
> no-auth-cache'. So I was just following the existing convention. Do
> you think we need to change it and stick with
> --catch-file-batch=1/--cat-file-batch=0 ?
Inventing a new --cat-file-batch=[0|1] is not
yle notes, I agree with them, will adjust the code.
--
Best Regards,
Victor
From: Junio C Hamano [jch2...@gmail.com] On Behalf Of Junio C Hamano
[gits...@pobox.com]
Sent: Monday, September 21, 2015 11:25 AM
To: Victor Leschuk
Cc: git@vger.kernel.org; Victor Leschuk
Sub
__
From: Junio C Hamano [jch2...@gmail.com] On Behalf Of Junio C Hamano
[gits...@pobox.com]
Sent: Monday, September 21, 2015 11:25 AM
To: Victor Leschuk
Cc: git@vger.kernel.org; Victor Leschuk
Subject: Re: [PATCH] git-svn: make batch mode optional for git-cat-file
Victor Leschu
Victor Leschuk writes:
> Signed-off-by: Victor Leschuk
> ---
Before the S-o-b line is a good place to explain why this is a good
change to have. Please use it.
> git-svn.perl | 1 +
> perl/Git.pm | 41 -
> 2 files changed, 41 insertions(+), 1 deletio
Eric Wong venit, vidit, dixit 10.09.2015 20:08:
> Michael J Gruber wrote:
>> Instead, make git svn uses the perl regex
>>
>> /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.*)>\s*$/
>>
>> for parsing the authors file so that the same (slightly more lenient)
>> regex is used in both cases.
>>
>> Reported-by
Eric Wong writes:
> Michael J Gruber wrote:
>> Instead, make git svn uses the perl regex
>>
>> /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.*)>\s*$/
>>
>> for parsing the authors file so that the same (slightly more lenient)
>> regex is used in both cases.
>>
>> Reported-by: Till Schäfer
>> Signed
Michael J Gruber wrote:
> Instead, make git svn uses the perl regex
>
> /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.*)>\s*$/
>
> for parsing the authors file so that the same (slightly more lenient)
> regex is used in both cases.
>
> Reported-by: Till Schäfer
> Signed-off-by: Michael J Gruber
Tha
Junio C Hamano wrote:
> Ryuichi Kokubo writes:
>
> > git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
> > But lowercase %s formatting character is a GNU extention. This causes
> > problem
> > in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
Ryuichi Kokubo writes:
> git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
> But lowercase %s formatting character is a GNU extention. This causes problem
> in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
> Using Time::Local::timelocal($sec, $
Eric,
I'm sorry, but this change isn't important enough for me to follow up.
Please merge the other two patches, if you think they're good.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
Ramkumar Ramachandra wrote:
> The working_head_info routine takes a very long time to execute on large
> repositories. The least we can do is to comfort users that some progress
> is being made.
>
> Signed-off-by: Ramkumar Ramachandra
> ---
> I was worried because of the long wait, so I wrote t
Ramkumar Ramachandra wrote:
>> It is functional, maybe someone will use GIT_SVN_ID=0 ?
>
> Right. Kindly drop the first hunk.
Amendment: there are actually many other places where variables are
checked without "defined", so I doubt we want to put up with the extra
ugliness to allow "0".
--
To unsu
Eric Wong wrote:
> It is functional, maybe someone will use GIT_SVN_ID=0 ?
Right. Kindly drop the first hunk.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric Wong wrote:
> How portable is open on a directory? Perhaps it'd be better to
> check if it's a file, first:
Sure, that works; feel free to fix it up locally before committing.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.
Ramkumar Ramachandra wrote:
> Ramkumar Ramachandra wrote:
> > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
> > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} :
> > 'git-svn';
>
> This is probably not a functional change; please look at the second hunk.
It is funct
Ramkumar Ramachandra wrote:
> +++ b/git-svn.perl
> @@ -337,6 +337,10 @@ for (my $i = 0; $i < @ARGV; $i++) {
> # make sure we're always running at the top-level working directory
> if ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) {
> $ENV{GIT_DIR} ||= ".git";
> + # catch the submodule
Ramkumar Ramachandra wrote:
> -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
> +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} :
> 'git-svn';
This is probably not a functional change; please look at the second hunk.
--
To unsubscribe from this list: send the line "unsu
> On Dec 8, 2014, at 1:36 PM, Eric Wong wrote:
>
> Alfred Perlstein wrote:
>> Appearing here:
>> http://marc.info/?l=git&m=125259772625008&w=2
>
> Probably better to use a mid URL here, too
>
> http://mid.gmane.org/1927112650.1281253084529659.javamail.r...@klofta.sjsoft.com
>
> such a long
Alfred Perlstein wrote:
> Appearing here:
> http://marc.info/?l=git&m=125259772625008&w=2
Probably better to use a mid URL here, too
http://mid.gmane.org/1927112650.1281253084529659.javamail.r...@klofta.sjsoft.com
such a long URL, though...
> --- a/perl/Git/SVN/Editor.pm
> +++ b/perl/Git/SVN
On 12/6/14, 9:42 PM, Eric Wong wrote:
Alfred Perlstein wrote:
This change allows git-svn to support setting subversion properties.
Very useful for manually setting properties when committing to a
subversion repo that *requires* properties to be set without requiring
moving your changeset to s
On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein wrote:
> I have incorporated Eric Wong's feedback into the git-svn propset support
> patch.
>
> There is a nit that I want to point out. The code does not support adding
> props
> unless there are also content changes to the files as well. You c
On Sun, Dec 7, 2014 at 3:00 AM, Torsten Bögershausen wrote:
> On 2014-12-07 06.45, Torsten Bögershausen wrote:
> []
>>> +
>>> +test_expect_success 'add multiple props' '
>>> +git svn propset svn:keywords "FreeBSD=%H" foo &&
>>> +git svn propset fbsd:nokeywords yes foo &&
>>> +echo hell
On 2014-12-07 06.45, Torsten Bögershausen wrote:
[]
>> +
>> +test_expect_success 'add multiple props' '
>> +git svn propset svn:keywords "FreeBSD=%H" foo &&
>> +git svn propset fbsd:nokeywords yes foo &&
>> +echo hello >> foo &&
>> +git commit -m "testing propset" foo &&
>> +git
> diff --git a/t/t9148-git-svn-propset.sh b/t/t9148-git-svn-propset.sh
> new file mode 100755
> index 000..b36a8a2
> --- /dev/null
> +++ b/t/t9148-git-svn-propset.sh
> @@ -0,0 +1,71 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2014 Alfred Perlstein
> +#
> +
> +test_description='git svn propset test
Alfred Perlstein wrote:
> This change allows git-svn to support setting subversion properties.
>
> Very useful for manually setting properties when committing to a
> subversion repo that *requires* properties to be set without requiring
> moving your changeset to separate subversion checkout in o
Alfred Perlstein wrote:
> This change allows git-svn to support setting subversion properties.
>
> Very useful for manually setting properties when committing to a
> subversion repo that *requires* properties to be set without requiring
> moving your changeset to separate subversion checkout in o
Hin-Tak Leung wrote:
> Hmm, I see you are filing the problem against subversion. FWIW,
> I am currently using subversion-perl-1.8.10-1.fc20.x86_64 package on fedora
> 20.
> I'll possibly think about filing one under redhat's bugzilla and
> let them take it upward too.
This is another problem wit
Hmm, I see you are filing the problem against subversion. FWIW,
I am currently using subversion-perl-1.8.10-1.fc20.x86_64 package on fedora 20.
I'll possibly think about filing one under redhat's bugzilla and
let them take it upward too.
On Fri, 31/10/1
Eric Wong wrote:
> + SVN::Core->gpool->clear;
Unfortunately, SVN::Core->gpool is not available in older SVN,
but I'm cooking a better patch which saves even more memory.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to major
Tommaso Colombo wrote:
> When populating svn:mergeinfo, git-svn merge checks if the merge parent
> of the merged branch is under the same root as the git-svn repository.
> This was implemented comparing $gs->repos_root with the return value of
> of cmt_metadata for the merge parent. However, the f
Eric Wong writes:
> On my Debian 7 system, this gives annoying warnings when the output
> of "git svn" commands are redirected:
>
> Unable to get Terminal Size. The TIOCGWINSZ ioctl didn't work.
> The COLUMNS and LINES environment variables didn't work. The
> resize program didn't wor
Eric Wong wrote:
> On my Debian 7 system, this gives annoying warnings when the output
s/gives/fixes/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Andrej Manduch wrote:
> On 08/03/2014 02:22 PM, Andrej Manduch wrote:
> > Nice touch, It works like charm. However unfortunatelly now I think you
> > introduced new bug :)
Good catch!
> > On 08/03/2014 04:45 AM, Eric Wong wrote:
> >> sub cmd_info {
> >> - my $path = canonicalize_path(defined($
On 08/03/2014 02:22 PM, Andrej Manduch wrote:
> Hi Eric,
>
> Nice touch, It works like charm. However unfortunatelly now I think you
> introduced new bug :)
>
> On 08/03/2014 04:45 AM, Eric Wong wrote:
>> Hi Andrej, I could not help thinking your patch was obscuring
>> another bug. I think I hav
Hi Eric,
Nice touch, It works like charm. However unfortunatelly now I think you
introduced new bug :)
On 08/03/2014 04:45 AM, Eric Wong wrote:
> Hi Andrej, I could not help thinking your patch was obscuring
> another bug. I think I have an alternative to your patch which
> fixes both our bugs.
Andrej Manduch wrote:
> On 07/24/2014 12:04 AM, Eric Wong wrote:
> > Andrej Manduch wrote:
> >> * this fixes 'git svn info `pwd`' buggy behaviour
> >
> > While your patch avoids an error, but the output isn't right, either.
> > I tried it running in /home/ew/ruby, the URL field is bogus:
> Thx,
Le 02/08/2014 12:07, Eric Wong a écrit :
Thanks. In the future, it's expected to Cc: anybody who showed interest
in previous versions of your patch.
Monard Vong wrote:
When a client certificate is required to connect to a Subversion repository,
the certificate location and password may be sto
Thanks. In the future, it's expected to Cc: anybody who showed interest
in previous versions of your patch.
Monard Vong wrote:
> When a client certificate is required to connect to a Subversion repository,
> the certificate location and password may be stored in Subversion config
> directory.
>
Hi,
On 07/24/2014 12:04 AM, Eric Wong wrote:
> Andrej Manduch wrote:
>> * this fixes 'git svn info `pwd`' buggy behaviour
>
> Good catch, the commit could use a better description, something like:
> --- 8<
> Subject: [PATCH] git-svn: "info" ch
Thanks for your reply, I updated commit message and subject, hoping it
would be clearer.
However I messed up "message-id" so it appear as a new message and not
in the current thread.
Sorry, still learning.
Le 24/07/2014 00:33, Eric Wong a écrit :
Monard Vong wrote:
If a client certificate i
Monard Vong wrote:
> If a client certificate is required to connect to svn, "git svn branch"
> always prompt the user for the certificate location and password,
> even though those parameters are stored in svn file "server"
> located in svn config dir (generally ~/.subversion).
> On the opposite,
Andrej Manduch wrote:
> * this fixes 'git svn info `pwd`' buggy behaviour
Good catch, the commit could use a better description, something like:
--- 8<
Subject: [PATCH] git-svn: "info" checks for dirs more carefully
This avoids a "Reading from
I'm sorry, i've made mistake in this one. Please ingnore it. Correct
patch is on the way.
kind regards,
b.
On Fri, Jul 18, 2014 at 6:05 AM, Andrej Manduch wrote:
> * this fixes 'git svn info `pwd`' buggy behaviour
>
> Signed-off-by: Andrej Manduch
> ---
> git-svn.perl | 2 +-
> 1 file changed
2013/12/30 Thomas Rast :
> Roman Kagan writes:
>
>> + # workaround for a bug in svn serf backend (v1.8.5 and below):
>> + # store 3d argument to ->add_file() in a local variable, to make it
>> + # have the same lifetime as $fbat
>> + my $upa = $self->url_path($m->{file_a});
>>
Roman Kagan writes:
> + # workaround for a bug in svn serf backend (v1.8.5 and below):
> + # store 3d argument to ->add_file() in a local variable, to make it
> + # have the same lifetime as $fbat
> + my $upa = $self->url_path($m->{file_a});
> my $fbat = $self->add_file($sel
2013/12/27 Roman Kagan :
> 2013/12/27 Jonathan Nieder :
>> Could this be reproduced with a test script to make sure we don't
>> reintroduce the bug again later? (It's okay if the test only fails on
>> machines with the problematic svn version.)
>
> That would need a fairly fancy setup phase, as th
2013/12/27 Jonathan Nieder :
> Roman Kagan wrote:
>
>> Subversion serf backend in versions 1.8.5 and below has a bug that the
>> function creating the descriptor of a file change -- add_file() --
>> doesn't make a copy of its 3d argument when storing it on the returned
>
> 3d makes me think of 3-di
Roman Kagan wrote:
> Subversion serf backend in versions 1.8.5 and below has a bug that the
> function creating the descriptor of a file change -- add_file() --
> doesn't make a copy of its 3d argument when storing it on the returned
3d makes me think of 3-dimensional. ;-) I think you mean third
Aleksey Vasenev wrote:
> ---
What Thomas said about commit messages.
Note: I hardly use git-svn or SVN anymore and don't pay attention
to SVN changes.
Some style nitpicks:
> @@ -1304,16 +1318,20 @@ sub cmd_create_ignore {
> # which git won't track
> mkpath([$path])
Hi Aleksey
Thanks for your patch. I added Eric Wong to the Cc list; all git-svn
patches should go to him.
Aleksey Vasenev writes:
> ---
Can you write a commit message? If you need a guideline for what to
write there, consider this snippet from Documentation/SubmittingPatches:
The body sho
Stefan Beller writes:
> While I can understand 4 or 7 white spaces are fancy, we'd rather want
> to use tabs throughout the whole document.
You missed lines 278 and 833. There are also some spaces around line
488, but maybe those are layout-relevant and so shouldn't be converted
to tabs.
-Kesh
Jonathan Nieder wrote:
> Nicolas Vigier wrote:
>
> > When parsing a commit object, git-svn wrongly think that a line
> > containing spaces means the end of headers and the start of the commit
> > message. In case of signed commit, the gpgsig entry contains a line with
> > one space, so "git svn d
Nicolas Vigier wrote:
> When parsing a commit object, git-svn wrongly think that a line
> containing spaces means the end of headers and the start of the commit
> message. In case of signed commit, the gpgsig entry contains a line with
> one space, so "git svn dcommit" will include part of the sig
"Uli Heller" writes:
> On Fri, September 6, 2013 2:44 pm, Kyle J. McKay wrote:
> ...
>> In any case, I can now reproduce the problem (serf 1.3.1 still breaks
>> since it does not yet contain the fix and it is the most recent serf
>> release available).
>>
>> And the Git/SVN/Ra.pm fix does elimina
On Fri, September 6, 2013 2:44 pm, Kyle J. McKay wrote:
> On Sep 6, 2013, at 05:06, Uli Heller wrote:
>>> I'm using Git built from master (57e4c1783). I see the same behavior
>>> both with and without the SVN/Ra.pm patch (and using both bulk
>>> updates
>>> and skelta mode). Does the problem not
On Sep 5, 2013, at 11:48, Junio C Hamano wrote:
I am Cc'ing Kyle McKay who apparently had some experience working
with git-svn with newer svn that can only use serf, hoping that we
can get an independent opinion/test just to be sure.
On Sep 3, 2013, at 00:35, Uli Heller wrote:
When using git-s
1 - 100 of 133 matches
Mail list logo
