RE: [Nit] Lots of enumerated type warnings

2018-01-22 Thread Randall S. Becker
On January 22, 2018 6:44 PM, Junio C Hamano wrote: > > "Randall S. Becker" writes: > > > Here are a few examples, there are more: > > > > auto_crlf = git_config_bool(var, value); > > ^ > > The carets in your message do not align to what I think they are trying to > point a

Re: [Nit] Lots of enumerated type warnings

2018-01-22 Thread Junio C Hamano
"Randall S. Becker" writes: > Here are a few examples, there are more: > > auto_crlf = git_config_bool(var, value); > ^ The carets in your message do not align to what I think they are trying to point at, but I think the above is pointing at the '=' and wants to say "auto

RE: [Nit] Lots of enumerated type warnings

2018-01-22 Thread Randall S. Becker
On January 22, 2018 5:41 PM, Junio C Hamano wrote: > "Randall S. Becker" writes: > > > I'm seeing an increase in the enumerated type warnings coming from my > > use of the c99 compiler for compiling git over time (loads more for > > 2.16.0 compared to 2.3.7 when I took it on). > > What exactly d

Re: [Nit] Lots of enumerated type warnings

2018-01-22 Thread Junio C Hamano
"Randall S. Becker" writes: > I'm seeing an increase in the enumerated type warnings > coming from my use of the c99 compiler for compiling git over time (loads > more for 2.16.0 compared to 2.3.7 when I took it on). What exactly do these "warnings" complain about? Without knowing that, the rem