Re: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-15 Thread Junio C Hamano
"Randall S. Becker" writes: > As a suggestion, with people who know how to escape stuff properly > (or not), perhaps we can select the alternate behaviour explicitly > using a core.sshIgnoreEscape=true/false option. Thoughts on that? The semantics of prepare_shell_cmd() is, regardless of any "fu

RE: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-15 Thread Randall S. Becker
On April 15, 2019 17:14, Andreas Schwab wrote: > On Apr 15 2019, "Randall S. Becker" wrote: > > > on virtually any platform at my disposal (Windows, Ubuntu, MacOS, the > > older NonStop variant), and have that work with no problem. Somewhere > > after get_ssh_command(), the command is being inter

Re: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-15 Thread Johannes Sixt
Am 15.04.19 um 21:20 schrieb Randall S. Becker: > What is strange is that GIT_SSH_COMMAND='/usr/bin/ssh -v' should not > execute if we are just looking at an object path. It should be broken > into '/usr/bin/ssh' and '-v' otherwise spawn* or exec* will not > execute it. I'm still trying to understa

Re: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-15 Thread Andreas Schwab
On Apr 15 2019, "Randall S. Becker" wrote: > on virtually any platform at my disposal (Windows, Ubuntu, MacOS, the > older NonStop variant), and have that work with no problem. Somewhere > after get_ssh_command(), the command is being interpreted it its parts > either as a shell or something else

RE: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-15 Thread Randall S. Becker
On April 13, 2019 17:48, SZEDER Gábor wrote: > On Sat, Apr 13, 2019 at 10:39:35PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Apr 13 2019, Randall S. Becker wrote: > > > > > I am encountering a problem on one of our NonStop platform variants > > > where the GIT_SSH_COMMAND string is not being

RE: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-14 Thread Randall S. Becker
On April 13, 2019 17:48, SZEDER Gábor wrote: > To: Ævar Arnfjörð Bjarmason > Cc: Randall S. Becker ; git@vger.kernel.org > Subject: Re: [BUG] GIT_SSH_COMMAND is not being decomposed > > On Sat, Apr 13, 2019 at 10:39:35PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Sat, A

Re: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-13 Thread SZEDER Gábor
On Sat, Apr 13, 2019 at 10:39:35PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Apr 13 2019, Randall S. Becker wrote: > > > I am encountering a problem on one of our NonStop platform variants where > > the GIT_SSH_COMMAND string is not being broken into constituent parts. This > > is causing

RE: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-13 Thread Randall S. Becker
On April 13, 2019 16:40, Ævar Arnfjörð Bjarmason wrote: > On Sat, Apr 13 2019, Randall S. Becker wrote: > > > I am encountering a problem on one of our NonStop platform variants > > where the GIT_SSH_COMMAND string is not being broken into constituent > > parts. This is causing SSH to not run prop

Re: [BUG] GIT_SSH_COMMAND is not being decomposed

2019-04-13 Thread Ævar Arnfjörð Bjarmason
On Sat, Apr 13 2019, Randall S. Becker wrote: > I am encountering a problem on one of our NonStop platform variants where > the GIT_SSH_COMMAND string is not being broken into constituent parts. This > is causing SSH to not run properly. As background, SSH is not in a standard > location and has