Re: Make git-svn Use accessors for paths and urls

2012-07-28 Thread Jonathan Nieder
Michael G Schwern wrote: > On 2012.7.27 8:10 PM, Jonathan Nieder wrote: >> If you have a chance at some point to offer advice, I'd love to add >> the information to Documentation/SubmittingPatches that was missing. [...] > Remind me when I'm done with the 1.7 fix please? Sure, if I remember to. :

Re: Make git-svn Use accessors for paths and urls

2012-07-28 Thread Michael G Schwern
On 2012.7.27 8:10 PM, Jonathan Nieder wrote: >> This is the last refactoring patch series. After this bugs, start >> getting fixed. > > I just wanted to say thanks for your thoughtful presentation of this > code. I was worried before, but these have been pleasantly submitted. You're welcome. I

Re: Make git-svn Use accessors for paths and urls

2012-07-27 Thread Jonathan Nieder
Michael G. Schwern wrote: > This is the last refactoring patch series. After this bugs, start > getting fixed. I just wanted to say thanks for your thoughtful presentation of this code. I was worried before, but these have been pleasantly submitted. If you have a chance at some point to offer

Make git-svn Use accessors for paths and urls

2012-07-27 Thread Michael G. Schwern
This patch series gives Git::SVN and Git::SVN::Ra accessors for path and url and then makes the rest of the code use them, rather than grab at $obj->{path} and $obj->{url}. This then will give us the control necessary to canonicalize them as early as possible (done in the next patch series). Ther