Re: Inconsistent results of git blame --porcelain when detecting copies from other files

2017-02-21 Thread Jeff King
On Tue, Feb 21, 2017 at 12:25:37PM +, Sokolov, Konstantin wrote: > Thanks for going into the issue. As far as I understand 2.12 won't > change the discussed behavior of --procelain. We will switch to > --line-procelain. After the current discussion it seems to be less > error prone, more futur

AW: Inconsistent results of git blame --porcelain when detecting copies from other files

2017-02-21 Thread Sokolov, Konstantin
gards Konstantin -Ursprüngliche Nachricht- Von: Jeff King [mailto:p...@peff.net] Gesendet: Montag, 20. Februar 2017 23:16 An: Junio C Hamano Cc: Sokolov, Konstantin (ext) (CT RDA SSI ADM-DE); git@vger.kernel.org Betreff: Re: Inconsistent results of git blame --porcelain when detecting c

Re: Inconsistent results of git blame --porcelain when detecting copies from other files

2017-02-20 Thread Junio C Hamano
Jeff King writes: > The simplest way (IMHO) to parse --porcelain output is: > > - maintain a mapping of commit sha1s to the commit's details > > - whenever you see a " []" > line, any key-value fields which follow impact _only_ that sha1, and > you should update the details for that

Re: Inconsistent results of git blame --porcelain when detecting copies from other files

2017-02-20 Thread Jeff King
On Mon, Feb 20, 2017 at 01:30:29PM -0800, Junio C Hamano wrote: > "Sokolov, Konstantin" writes: > > > However, when using --porcelain DirectoryReader.java is reported as the > > origin of lines 502-504: > > ... > > This is not only inconsistent with the other outputs but the output is also > >

Re: Inconsistent results of git blame --porcelain when detecting copies from other files

2017-02-20 Thread Junio C Hamano
"Sokolov, Konstantin" writes: > However, when using --porcelain DirectoryReader.java is reported as the > origin of lines 502-504: > ... > This is not only inconsistent with the other outputs but the output is also > inconsistent in itself because lines 496 -498 do not even exist in a previous

Inconsistent results of git blame --porcelain when detecting copies from other files

2017-02-20 Thread Sokolov, Konstantin
Hi Folks! The issue is best explained on an example. You can reproduce it using the Lucene repo https://github.com/apache/lucene-solr.git. Tested with the following versions: 1.8.1.6 (Ubuntu), 2.11.0.windows.1, 2.11.1.windows.1. First, let's produce the correct results without using --procelai