Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-13 Thread Johannes Schindelin
Hi, On Tue, 12 Feb 2019, SZEDER Gábor wrote: > On Tue, Feb 12, 2019 at 02:14:56PM +0100, Ævar Arnfjörð Bjarmason wrote: > > > > On Tue, Feb 12 2019, Duy Nguyen wrote: > > > > > On Tue, Feb 12, 2019 at 7:43 PM Duy Nguyen wrote: > > >> The test failures on NetBSD and Solaris/Sparc, not sure if w

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Junio C Hamano
Junio C Hamano writes: > If I find time later in the day, I may forge your sign-off and > fabricate log messages for both patches, but unfortunately I need to > run a long errand today during the day, so it may not happen. And here is the other one. I have the s/is/if/ typofix already in there.

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Junio C Hamano
Junio C Hamano writes: > If I find time later in the day, I may forge your sign-off and > fabricate log messages for both patches, but unfortunately I need to > run a long errand today during the day, so it may not happen. Here is what I have, with forged sign-off. I am not merging them to 'nex

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Junio C Hamano
Junio C Hamano writes: > Duy Nguyen writes: > >> The AIX problem is from d1dd94b308 (Do not print 'dangling' for >> cat-file in case of ambiguity - 2019-01-17). Apparently AIX compiler >> is a bit picky about enum being a strong or weak type. I like this >> compiler. The below patch should do. >

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Junio C Hamano
Duy Nguyen writes: > The AIX problem is from d1dd94b308 (Do not print 'dangling' for > cat-file in case of ambiguity - 2019-01-17). Apparently AIX compiler > is a bit picky about enum being a strong or weak type. I like this > compiler. The below patch should do. That would cascade down the call

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Feb 12, 2019 at 01:13:35PM +0100, Ævar Arnfjörð Bjarmason wrote: >> >> On Thu, Feb 07 2019, Junio C Hamano wrote: >> >> > An early preview release Git v2.21.0-rc0 is now available for >> > testing at the usual places. It is comprised of 426 non-merge >> > commits s

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread SZEDER Gábor
On Tue, Feb 12, 2019 at 02:14:56PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Feb 12 2019, Duy Nguyen wrote: > > > On Tue, Feb 12, 2019 at 7:43 PM Duy Nguyen wrote: > >> The test failures on NetBSD and Solaris/Sparc, not sure if we can do > >> anything without test logs or access to these

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Feb 12 2019, Ævar Arnfjörð Bjarmason wrote: > On Tue, Feb 12 2019, Duy Nguyen wrote: > >> On Tue, Feb 12, 2019 at 7:43 PM Duy Nguyen wrote: >>> The test failures on NetBSD and Solaris/Sparc, not sure if we can do >>> anything without test logs or access to these systems. >> >> Actually

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Feb 12 2019, Duy Nguyen wrote: > On Tue, Feb 12, 2019 at 7:43 PM Duy Nguyen wrote: >> The test failures on NetBSD and Solaris/Sparc, not sure if we can do >> anything without test logs or access to these systems. > > Actually if you could tweak your ci script a bit to run tests with -v,

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Feb 12 2019, SZEDER Gábor wrote: > On Tue, Feb 12, 2019 at 01:13:35PM +0100, Ævar Arnfjörð Bjarmason wrote: >> As seen on https://gitlab.com/git-vcs/git-ci/branches there are >> regressions since 2.19.0, e.g. we have hard compile errors on BSD now, >> and maybe AIX. I haven't dug into it

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Duy Nguyen
On Tue, Feb 12, 2019 at 7:43 PM Duy Nguyen wrote: > The test failures on NetBSD and Solaris/Sparc, not sure if we can do > anything without test logs or access to these systems. Actually if you could tweak your ci script a bit to run tests with -v, that would help. -- Duy

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread SZEDER Gábor
On Tue, Feb 12, 2019 at 01:13:35PM +0100, Ævar Arnfjörð Bjarmason wrote: > As seen on https://gitlab.com/git-vcs/git-ci/branches there are > regressions since 2.19.0, e.g. we have hard compile errors on BSD now, > and maybe AIX. I haven't dug into it. Where exactly can we see those? Could you ple

Re: Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Duy Nguyen
On Tue, Feb 12, 2019 at 01:13:35PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Feb 07 2019, Junio C Hamano wrote: > > > An early preview release Git v2.21.0-rc0 is now available for > > testing at the usual places. It is comprised of 426 non-merge > > commits since v2.20.0, contributed by

Git v2.21.0-rc0 broken on *BSD, maybe others

2019-02-12 Thread Ævar Arnfjörð Bjarmason
On Thu, Feb 07 2019, Junio C Hamano wrote: > An early preview release Git v2.21.0-rc0 is now available for > testing at the usual places. It is comprised of 426 non-merge > commits since v2.20.0, contributed by 57 people, 13 of which are > new faces. As seen on https://gitlab.com/git-vcs/git-c