Re: Git on Mac OS and precomposed unicode

2013-03-21 Thread Leo Koppelkamm
I found the problem: I copied the config out of your commit message, where you wrote core.precomposedunicode Turns out the d is too much. It seems to work now. Leo On Thursday, 21 March 2013 at 17:04, Torsten Bögershausen wrote: > On 21.03.13 14:00, Leo Koppelkamm wrote: > > Torsten

Re: Git on Mac OS and precomposed unicode

2013-03-21 Thread Torsten Bögershausen
On 21.03.13 14:00, Leo Koppelkamm wrote: > Torsten Bögershausen added a patch for this a while ago. > It seems it only works for files, not for folders with unicode in it. > > Eg. on ubuntu box: > git init > mkdir hä > touch hä/file > git add hä > git commit > > Later on Mac > git clone ……… > git

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-08-16 Thread Junio C Hamano
Junio C Hamano writes: > Robin Rosenberg writes: > >> Just a couple of nitpicks. > > Polishing is always good and better late than never, but for a topic > that has long been graduated to 'master' already, it would be easier > to review and discuss if it came as a patch form relative to the > co

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-07-26 Thread Junio C Hamano
Robin Rosenberg writes: > Just a couple of nitpicks. Polishing is always good and better late than never, but for a topic that has long been graduated to 'master' already, it would be easier to review and discuss if it came as a patch form relative to the codebase _after_ the topic has been appl

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-07-26 Thread Robin Rosenberg
Just a couple of nitpicks. Torsten Bögershausen skrev 2012-07-08 15.50: diff --git a/compat/precompose_utf8.c b/compat/precompose_utf8.c [...] +static size_t has_utf8(const char *s, size_t maxlen, size_t *strlen_c) +{ + const uint8_t *utf8p = (const uint8_t*) s; + size_t strlen_cha

Re: [PATCH V4] git on Mac OS and precomposed unicode

2012-07-25 Thread Robin Rosenberg
Torsten Bögershausen skrev 2012-06-24 17.47: Do we have a motivation for pushing a solution that ignores the unicode composition ? I say we do. I tried your patch and it worked fine. I'll send a V5 version with hopefully a better motivation -- robin -- To unsubscribe from this list: send

[PATCH v9] git on Mac OS and precomposed unicode

2012-07-08 Thread Torsten Bögershausen
Mac OS X mangles file names containing unicode on file systems HFS+, VFAT or SAMBA. When a file using unicode code points outside ASCII is created on a HFS+ drive, the file name is converted into decomposed unicode and written to disk. No conversion is done if the file name is already decomposed u

Re: [PATCH v8] git on Mac OS and precomposed unicode

2012-07-08 Thread Andreas Schwab
Torsten Bögershausen writes: > Unlike on > HFS+, Mac OS X files on a VFAT drive (e.g. an USB drive), in ^stores? ^s/,// > precomposed unicode, but readdir() still returns file names in > decomposed unicode. Andreas. -- Andreas Schwab, sch...@lin

[PATCH v8] git on Mac OS and precomposed unicode

2012-07-08 Thread Torsten Bögershausen
Mac OS X mangles file names containing unicode on file systems HFS+, VFAT or SAMBA. When a file using unicode code points outside ASCII is created on a HFS+ drive, the file name is converted into decomposed unicode and written to disk. No conversion is done if the file name is already decomposed u