Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-07 Thread Junio C Hamano
Duy Nguyen writes: > On top of this, pickaxe already supports icase even kws is used. But > it only works for ascii, so either we fix it and support non-ascii, or > we remove icase support entirely from diffcore_pickaxe(). I vote the > former. I think that is a different issue. The pickaxe has

Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-07 Thread Duy Nguyen
On Wed, Jul 8, 2015 at 1:08 AM, Plamen Totev wrote: > Junio C Hamano writes: > >> Plamen Totev writes: >> >> > pickaxe search also uses kwsearch so the case insensitive search with >> > it does not work (e.g. git log -i -S). Maybe this is a less of a >> > problem here as one is expected to searc

Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-07 Thread Plamen Totev
Junio C Hamano writes: > Plamen Totev writes:  >  > > pickaxe search also uses kwsearch so the case insensitive search with  > > it does not work (e.g. git log -i -S). Maybe this is a less of a  > > problem here as one is expected to search for exact string (hence  > > knows the case)  >  > You

Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-07 Thread Junio C Hamano
Plamen Totev writes: > pickaxe search also uses kwsearch so the case insensitive search with > it does not work (e.g. git log -i -S). Maybe this is a less of a > problem here as one is expected to search for exact string (hence > knows the case) You reasoned correctly, I think. Pickaxe, as one

Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-07 Thread Duy Nguyen
efactor would be needed. "git grep regcomp" reveals some many places. Many some of them would benefit from kws if we provide this new function you mentioned. > Regards, > Plamen Totev > > > >> Оригинално писмо >>От: Duy Nguyen pclo...@gmail.com >>Относно: Re: Gi

Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-07 Thread Plamen Totev
Оригинално писмо >От: Duy Nguyen pclo...@gmail.com >Относно: Re: Git grep does not support multi-byte characters (like UTF-8) >До: Plamen Totev >Изпратено на: 06.07.2015 15:23 > I think we over-optimized a bit. If you your system provides regex > with loca

Re: Git grep does not support multi-byte characters (like UTF-8)

2015-07-06 Thread Duy Nguyen
On Mon, Jul 6, 2015 at 6:28 PM, Plamen Totev wrote: > Hello, > > It looks like the git grep command does not support multi-byte character sets > like UTF-8. As a result some of the grep functionality is not working. For > example if you search for non Latin words the ignore case flag does not ha

Git grep does not support multi-byte characters (like UTF-8)

2015-07-06 Thread Plamen Totev
Hello,  It looks like the git grep command does not support multi-byte character sets like UTF-8. As a result some of the grep functionality is not working. For example if you search for non Latin words the ignore case flag does not have effect(the search is case sensitive). I suspect there are