Re: Git commit amend empty emails

On Wed, Dec 10, 2014 at 10:46:16AM -0800, Junio C Hamano wrote: > > So we now notice the empty email in this code path, but the only thing > > we do is avoid writing out the environment variables and continue. Which > > means that the actual string generated by fmt_ident (complete with empty > > e

Re: Git commit amend empty emails

Jeff King writes: > However, there's something else going on. I am surprised that we allow > empty emails at all and the code here is quite strange. The first check > on the ident format is when we feed the data to fmt_ident to generate > the string that goes into the commit object. We disallow

Re: Git commit amend empty emails

On Thu, Dec 11, 2014 at 12:17:35AM +1100, Simon wrote: > Git is having empty email problems I think, I'm on git v2.1.3. > > Steps to reproduce: > > $ git init > Initialized empty Git repository in /tmp/test_git/.git/ > $ echo 'test' > abc > $ git add --all 1 ↵ > $ git commit

Git commit amend empty emails

Git is having empty email problems I think, I'm on git v2.1.3. Steps to reproduce: $ git init Initialized empty Git repository in /tmp/test_git/.git/ $ echo 'test' > abc $ git add --all 1 ↵ $ git commit --message 'test' [master (root-commit) 3cc2793] test 1 file chan