Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread erik elfström
Thanks for fixing the missing SANITY prerequisite Stefan. As for the error handling logic in setup.c: is_nonbare_repository_dir (was clean.c: is_git_repository) my reasoning is as follows: READ_GITFILE_ERR_STAT_FAILED READ_GITFILE_ERR_NOT_A_FILE: When checking random paths for .git files these a

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread Jeff King
On Tue, May 03, 2016 at 11:53:36AM -0700, Stefan Beller wrote: > > is related or worth doing on top. But I don't think so. That code is > > just trying to convert some error-cases into "let's err on the side of > > assuming it is a repo". Doing that for all values of gitfile_error is > > definitel

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread Stefan Beller
On Tue, May 3, 2016 at 11:48 AM, Jeff King wrote: > On Tue, May 03, 2016 at 11:05:09AM -0700, Junio C Hamano wrote: > >> On Tue, May 3, 2016 at 11:02 AM, Stefan Beller wrote: >> > >> > So I wonder if is_nonbare_repository_dir() is the culprit here. >> > (We do a chmod 0 on the .git before the `gi

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread Jeff King
On Tue, May 03, 2016 at 11:05:09AM -0700, Junio C Hamano wrote: > On Tue, May 3, 2016 at 11:02 AM, Stefan Beller wrote: > > > > So I wonder if is_nonbare_repository_dir() is the culprit here. > > (We do a chmod 0 on the .git before the `git clean` in the test to confuse > > Git) > > Ask if the

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread Junio C Hamano
On Tue, May 3, 2016 at 11:02 AM, Stefan Beller wrote: > > So I wonder if is_nonbare_repository_dir() is the culprit here. > (We do a chmod 0 on the .git before the `git clean` in the test to confuse > Git) Ask if the test is run as root; if so, then mark the test to require SANITY prerequisite.

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread Stefan Beller
On Tue, May 3, 2016 at 2:19 AM, Jan Keromnes wrote: > Thanks for your replies! I was able to reproduce to failure on Git 2.8.2. > > Steps: > > # Build Git 2.8.2 and run t/t7300-clean.sh in a Dockerfile based on > ubuntu:14.04. > RUN mkdir /tmp/git \ > && cd /tmp/git \ > && curl https://www.kerne

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-05-03 Thread Jan Keromnes
Thanks for your replies! I was able to reproduce to failure on Git 2.8.2. Steps: # Build Git 2.8.2 and run t/t7300-clean.sh in a Dockerfile based on ubuntu:14.04. RUN mkdir /tmp/git \ && cd /tmp/git \ && curl https://www.kernel.org/pub/software/scm/git/git-2.8.2.tar.xz | tar xJ \ && cd git-2.8

Re: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-04-29 Thread Stefan Beller
On Fri, Apr 29, 2016 at 5:53 AM, Jan Keromnes wrote: > Hello, > > I tried running a full profile build of Git 2.8.1, but it looks like > test #32 in `t7300-clean.sh` fails: > > Commands: > >> curl https://www.kernel.org/pub/software/scm/git/git-2.8.1.tar.xz | tar xJ >> cd git-2.8.1 >> make prefix=

Re: Fwd: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-04-29 Thread Johannes Schindelin
Hi Jan, On Fri, 29 Apr 2016, Jan Keromnes wrote: > I tried running a full profile build of Git 2.8.1, but it looks like > test #32 in `t7300-clean.sh` fails: > > Commands: > > > curl https://www.kernel.org/pub/software/scm/git/git-2.8.1.tar.xz | tar xJ > > cd git-2.8.1 > > make prefix=/usr prof

Fwd: Git 2.8.1 fails test 32 of t7300-clean.sh, breaks profile build

2016-04-29 Thread Jan Keromnes
Hello, I tried running a full profile build of Git 2.8.1, but it looks like test #32 in `t7300-clean.sh` fails: Commands: > curl https://www.kernel.org/pub/software/scm/git/git-2.8.1.tar.xz | tar xJ > cd git-2.8.1 > make prefix=/usr profile-install install-man -j18 Logs of test-suite that fails