Re: Fwd: bug: contrib/subtree: Commit message title should be in imperative mood

2017-08-04 Thread Bjørn Erik Pedersen
I would argue that: 1. If used on the "Git project itself" (as in my case), the commit message now cannot be used unedited because it is a conflict with the project's guidelines, and also conflicts with the format of "all" (or most) the other Git (and GitHub) commit titles. 2. If not "used on the

Re: Fwd: bug: contrib/subtree: Commit message title should be in imperative mood

2017-08-04 Thread Junio C Hamano
Bjørn Erik Pedersen writes: > I.e. "Squash 'somedir' changes" and not "Squashed ..." > > See > > https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463 I do not think this is necessarily a good change. "git subtree" (in contrib/) is not a tool limited to be used on projects

Fwd: bug: contrib/subtree: Commit message title should be in imperative mood

2017-08-04 Thread Bjørn Erik Pedersen
I.e. "Squash 'somedir' changes" and not "Squashed ..." See https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463