Re: Fixup of a fixup not working right

2016-09-07 Thread Johannes Schindelin
Hi Philip, On Tue, 6 Sep 2016, Philip Oakley wrote: > From: "Johannes Schindelin" > > > > On Sun, 4 Sep 2016, Philip Oakley wrote: > > > > > I suspect that some use cases have intermediate repositories that > > > contain a 'master' branch (it's just a name ;-) that isn't blessed > > > and golden

Re: Fixup of a fixup not working right

2016-09-06 Thread Philip Oakley
From: "Johannes Schindelin" Hi Philip, On Sun, 4 Sep 2016, Philip Oakley wrote: From: "Johannes Schindelin" > The point is that fixup! messages are really special, and are always > intended to be squashed into the referenced commit *before* the latter > hits `master`. I think it's here tha

Re: Fixup of a fixup not working right

2016-09-05 Thread Johannes Schindelin
Hi Philip, On Sun, 4 Sep 2016, Philip Oakley wrote: > From: "Johannes Schindelin" > > > The point is that fixup! messages are really special, and are always > > intended to be squashed into the referenced commit *before* the latter > > hits `master`. > > I think it's here that we have the hidd

Re: Fixup of a fixup not working right

2016-09-04 Thread Philip Oakley
From: "Johannes Schindelin" Hi Junio & Philip, On Fri, 2 Sep 2016, Junio C Hamano wrote: "Philip Oakley" writes: > As I understand this it's implied by design. The issue is that the > rebase is looking for that named commit within its current rebase > range, and can't find it, so ignores it

Re: Fixup of a fixup not working right

2016-09-04 Thread Johannes Schindelin
Hi Junio & Philip, On Fri, 2 Sep 2016, Junio C Hamano wrote: > "Philip Oakley" writes: > > > As I understand this it's implied by design. The issue is that the > > rebase is looking for that named commit within its current rebase > > range, and can't find it, so ignores it. > > > > There is a s

Re: Fixup of a fixup not working right

2016-09-03 Thread Philip Oakley
Hi Robert, From: "Robert Dailey" On Fri, Sep 2, 2016 at 9:22 PM, Junio C Hamano wrote: Perhaps a change like this to "rebase -i": - The search for "original" when handling "pick fixup! original", when it does not find "original", could turn it into "reword fixup! original" without chan

Re: Fixup of a fixup not working right

2016-09-03 Thread Robert Dailey
On Fri, Sep 2, 2016 at 9:22 PM, Junio C Hamano wrote: > Perhaps a change like this to "rebase -i": > > - The search for "original" when handling "pick fixup! original", >when it does not find "original", could turn it into "reword >fixup! original" without changing its position in the ins

Re: Fixup of a fixup not working right

2016-09-02 Thread Junio C Hamano
"Philip Oakley" writes: > As I understand this it's implied by design. The issue is that the > rebase is looking for that named commit within its current rebase > range, and can't find it, so ignores it. > > There is a separate issue that all the fixup! fixup! messages are > essentially treated a

Re: Fixup of a fixup not working right

2016-09-02 Thread Philip Oakley
From: "Robert Dailey" Suppose I have a branch with 4 commits, in the following order (as you might see during interactive rebase): pick 123 Original Change pick 789 fixup! Original Change pick 456 Some Other Thing pick abc fixup! fixup! Original Change However, let's say the first commit is al

Fixup of a fixup not working right

2016-09-02 Thread Robert Dailey
Suppose I have a branch with 4 commits, in the following order (as you might see during interactive rebase): pick 123 Original Change pick 789 fixup! Original Change pick 456 Some Other Thing pick abc fixup! fixup! Original Change However, let's say the first commit is already pushed upstream on