Re: Enhancements to git-protocoll

2012-07-30 Thread Sitaram Chamarty
On Mon, Jul 30, 2012 at 11:58 AM, Junio C Hamano wrote: > Shawn Pearce writes: > >>> The way to expose the extra information parsed by Git to the server >>> side could be made into calling out to hooks, and at that point, >>> gitolite would not even have to know about the pack protocol. >> >> Goo

Re: Enhancements to git-protocoll

2012-07-30 Thread Sitaram Chamarty
On Mon, Jul 30, 2012 at 11:58 AM, Junio C Hamano wrote: > Heh. While I do not particularly consider auto-creation-upon-push a > useful thing to begin with (after all, once you created a > repository, you would want ways to manage it, setting up ACL for it [side point] these things are managed w

Re: Enhancements to git-protocoll

2012-07-29 Thread Junio C Hamano
Shawn Pearce writes: >> The way to expose the extra information parsed by Git to the server >> side could be made into calling out to hooks, and at that point, >> gitolite would not even have to know about the pack protocol. > > Good point. The case that spawned this thread however still has a >

Re: Enhancements to git-protocoll

2012-07-29 Thread Shawn Pearce
On Sun, Jul 29, 2012 at 7:38 PM, Junio C Hamano wrote: > Shawn Pearce writes: > >> We sort of want this in Gerrit Code Review to pass reviewer names on >> the command line of git push, making it easier for users to upload a >> code review. The idea is similar to what happens with gcc accepting >>

Re: Enhancements to git-protocoll

2012-07-29 Thread Junio C Hamano
Shawn Pearce writes: > We sort of want this in Gerrit Code Review to pass reviewer names on > the command line of git push, making it easier for users to upload a > code review. The idea is similar to what happens with gcc accepting > linker flags that are just passed onto the linker. For review

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Mon, Jul 30, 2012 at 6:58 AM, Junio C Hamano wrote: > Sitaram Chamarty writes: > >> As I may have said earlier, this interaction is far too site-specific >> to be rolled into git itself. >> >> How about a new hook instead? A pre-pack-protocol hook that acts as >> if it was called by the remot

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Mon, Jul 30, 2012 at 6:51 AM, Shawn Pearce wrote: > On Sun, Jul 29, 2012 at 6:04 PM, Sitaram Chamarty wrote: >> Of course this will only work with ssh. None of what Fredrik has so >> far suggested would possibly work on smart http without even more >> hacks, I think. > > Now that we have smar

Re: Enhancements to git-protocoll

2012-07-29 Thread Junio C Hamano
Sitaram Chamarty writes: > As I may have said earlier, this interaction is far too site-specific > to be rolled into git itself. > > How about a new hook instead? A pre-pack-protocol hook that acts as > if it was called by the remote user as a command, and if it exit's > with 0, then the real pa

Re: Enhancements to git-protocoll

2012-07-29 Thread Shawn Pearce
On Sun, Jul 29, 2012 at 6:04 PM, Sitaram Chamarty wrote: > Of course this will only work with ssh. None of what Fredrik has so > far suggested would possibly work on smart http without even more > hacks, I think. Now that we have smart HTTP, and its somewhat popular for sites to deploy with, we

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Mon, Jul 30, 2012 at 3:08 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Sitaram Chamarty writes: >> >>> Uggh, no. Client-git should only talk to server-git. It shouldn't be >>> talking first to some *other* program (in this case gitolite), and >>> then to to server-git. That does

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Mon, Jul 30, 2012 at 2:56 AM, Fredrik Gustafsson wrote: > Sorry I missed this thread earlier. I'll drop this if it's not something > that's wanted. > > On Sun, Jul 29, 2012 at 01:51:34PM -0700, Junio C Hamano wrote: >> Sitaram Chamarty writes: >> >> > Uggh, no. Client-git should only talk to

Re: Enhancements to git-protocoll

2012-07-29 Thread Junio C Hamano
Junio C Hamano writes: > Sitaram Chamarty writes: > >> Uggh, no. Client-git should only talk to server-git. It shouldn't be >> talking first to some *other* program (in this case gitolite), and >> then to to server-git. That doesn't sound sane to me. >> >> You should wrap this whole thing aro

Re: Enhancements to git-protocoll

2012-07-29 Thread Fredrik Gustafsson
Sorry I missed this thread earlier. I'll drop this if it's not something that's wanted. On Sun, Jul 29, 2012 at 01:51:34PM -0700, Junio C Hamano wrote: > Sitaram Chamarty writes: > > > Uggh, no. Client-git should only talk to server-git. It shouldn't be > > talking first to some *other* progra

Re: Enhancements to git-protocoll

2012-07-29 Thread Junio C Hamano
Sitaram Chamarty writes: > Uggh, no. Client-git should only talk to server-git. It shouldn't be > talking first to some *other* program (in this case gitolite), and > then to to server-git. That doesn't sound sane to me. > > You should wrap this whole thing around something else that does it i

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Sun, Jul 29, 2012 at 9:11 PM, Fredrik Gustafsson wrote: > On Sun, Jul 29, 2012 at 08:45:39PM +0530, Sitaram Chamarty wrote: >> I think you misunderstood how gitolite works. Gitolite does not have >> *any* user interaction other than sending some extra messages back via >> STDERR if you're usin

Re: Enhancements to git-protocoll

2012-07-29 Thread Fredrik Gustafsson
On Sun, Jul 29, 2012 at 08:45:39PM +0530, Sitaram Chamarty wrote: > I think you misunderstood how gitolite works. Gitolite does not have > *any* user interaction other than sending some extra messages back via > STDERR if you're using a normal git client to do normal git operations > (clone/fetch/

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Sun, Jul 29, 2012 at 8:35 PM, Fredrik Gustafsson wrote: > On Sun, Jul 29, 2012 at 07:55:36PM +0530, Sitaram Chamarty wrote: >> > Thanks, however I think auto-creation is a great feature for some cases >> > and I think there can be even more useable functions if we could get >> > user interactio

Re: Enhancements to git-protocoll

2012-07-29 Thread Fredrik Gustafsson
On Sun, Jul 29, 2012 at 07:55:36PM +0530, Sitaram Chamarty wrote: > > Thanks, however I think auto-creation is a great feature for some cases > > and I think there can be even more useable functions if we could get > > user interaction. > > For the record, I don't think I agree. There's a place t

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Sun, Jul 29, 2012 at 7:54 PM, Fredrik Gustafsson wrote: > On Sat, Jul 28, 2012 at 11:58:09PM -0700, Junio C Hamano wrote: >> Fredrik Gustafsson writes: >> >> > Sometimes the server wants to communicate directly to the git user. >> > ... >> > For example: >> > gitolite has something called wild

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Sun, Jul 29, 2012 at 7:43 PM, Fredrik Gustafsson wrote: > On Sun, Jul 29, 2012 at 04:07:13PM +0530, Sitaram Chamarty wrote: >> On Sun, Jul 29, 2012 at 3:11 AM, Fredrik Gustafsson wrote: >> > Hi, >> > sometimes git communicates with something that's not git on the other >> > side (gitolite and

Re: Enhancements to git-protocoll

2012-07-29 Thread Fredrik Gustafsson
On Sat, Jul 28, 2012 at 11:58:09PM -0700, Junio C Hamano wrote: > Fredrik Gustafsson writes: > > > Sometimes the server wants to communicate directly to the git user. > > ... > > For example: > > gitolite has something called wild repos[1]. The management is > > cumbersome and if you misspell whe

Re: Enhancements to git-protocoll

2012-07-29 Thread Fredrik Gustafsson
On Sun, Jul 29, 2012 at 04:07:13PM +0530, Sitaram Chamarty wrote: > On Sun, Jul 29, 2012 at 3:11 AM, Fredrik Gustafsson wrote: > > Hi, > > sometimes git communicates with something that's not git on the other > > side (gitolite and github for example). > > > > Sometimes the server wants to communi

Re: Enhancements to git-protocoll

2012-07-29 Thread Sitaram Chamarty
On Sun, Jul 29, 2012 at 3:11 AM, Fredrik Gustafsson wrote: > Hi, > sometimes git communicates with something that's not git on the other > side (gitolite and github for example). > > Sometimes the server wants to communicate directly to the git user. > > git isn't really designed for this. gitolit

Re: Enhancements to git-protocoll

2012-07-28 Thread Junio C Hamano
Fredrik Gustafsson writes: > Sometimes the server wants to communicate directly to the git user. > ... > For example: > gitolite has something called wild repos[1]. The management is > cumbersome and if you misspell when you clone a repo you might instead > create a new repo. > > This could have

Enhancements to git-protocoll

2012-07-28 Thread Fredrik Gustafsson
Hi, sometimes git communicates with something that's not git on the other side (gitolite and github for example). Sometimes the server wants to communicate directly to the git user. git isn't really designed for this. gitolite solves this by do user interaction on STDERR instead. The bad thing ab