Re: Cherry-picking commits with empty messages

2012-08-02 Thread Neil Horman
On Wed, Aug 01, 2012 at 10:52:34AM -0700, Junio C Hamano wrote: > Chris Webb writes: > > [summary: this, when 59a8fde does not have any commit log message, > refuses to commit] > Thanks for CC'ing me on this. I'm on vacation currently, but will look at this in detail as soon as I'm back next we

Re: Cherry-picking commits with empty messages

2012-08-02 Thread Angus Hammond
On 1 August 2012 23:26, Junio C Hamano wrote: > I've read your entire response three times, and I am having a hard > time deciding if you are against my suggestion, or you misread my > suggestion. My apologies, I can see how my message wasn't as clear as it could have been. > I guess by "perpetu

Re: Cherry-picking commits with empty messages

2012-08-02 Thread Chris Webb
Junio C Hamano writes: > My recommendation, backed by the above line of thought, is to add > support for the "--allow-empty-message" option to both "rebase [-i]" > and "cherry-pick", defaulting to false. Thanks for the very detailed analysis and advice Junio. I like your suggested --allow-empty-

Re: Cherry-picking commits with empty messages

2012-08-01 Thread Junio C Hamano
Angus Hammond writes: >>But from the bigger UI consistency point of view, it would be >>chaotic to change the default of some options for a single >>command depending on the nature of the operand, so I would >>recommend against going this route, and pick one view between >>"gi

Re: Cherry-picking commits with empty messages

2012-08-01 Thread Angus Hammond
>But from the bigger UI consistency point of view, it would be >chaotic to change the default of some options for a single >command depending on the nature of the operand, so I would >recommend against going this route, and pick one view between >"give the user a chance to fix"

Re: Cherry-picking commits with empty messages

2012-08-01 Thread Junio C Hamano
Chris Webb writes: [summary: this, when 59a8fde does not have any commit log message, refuses to commit] > $ git cherry-pick 59a8fde > Aborting commit due to empty commit message. > I can see that this check could make sense when the message has been > modified, but it seems strange when it

Cherry-picking commits with empty messages

2012-08-01 Thread Chris Webb
Whilst doing some extra sanity checking of my git-rebase--interactive.sh patch yesterday, I came across a behaviour which has been present for some time, but seems surprising. You can reproduce with $ git init -q foo && cd foo $ touch one && git add one && git commit -q -m one $ touch two &&