Re: Bug report about symlinks

2014-08-04 Thread Junio C Hamano
René Scharfe writes: > Am 03.08.2014 um 19:19 schrieb Junio C Hamano: > >>> And do we need to use the threaded_ variant of the function here? >> >> Hmmm, this is a tangent, but you comment made me wonder if we also >> need to adjust preload_thread() in preload-index.c somehow, but we >> do not to

Re: Bug report about symlinks

2014-08-04 Thread Junio C Hamano
Duy Nguyen writes: > Just checking, you meant CE_UPTODATE, not CE_VALID, right? CE_VALID is > only used with --assume-unchanged Yup. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: Bug report about symlinks

2014-08-04 Thread Duy Nguyen
On Mon, Aug 4, 2014 at 12:19 AM, Junio C Hamano wrote: > I think you, who dug to find out where to add the check, already > know this, and I am writing this mainly for myself and for the list > archive, but when the knee-jerk "has-syjmlink-leading-path missing?" > reaction came to me, two obvious

Re: Bug report about symlinks

2014-08-03 Thread René Scharfe
Am 03.08.2014 um 19:19 schrieb Junio C Hamano: René Scharfe writes: How about the patch below? Before it checks if an index entry exists in the work tree, it checks if its path includes a symlink. Honestly, I didn't expect the fix to be in the refresh-index code path, but doing this there s

Re: Bug report about symlinks

2014-08-03 Thread Junio C Hamano
René Scharfe writes: > How about the patch below? Before it checks if an index entry exists > in the work tree, it checks if its path includes a symlink. Honestly, I didn't expect the fix to be in the refresh-index code path, but doing this there sort of makes sense. I think you, who dug to fi

Re: Bug report about symlinks

2014-08-02 Thread René Scharfe
Am 01.08.2014 um 18:23 schrieb Junio C Hamano: > René Scharfe writes: > >> # Create test repo with two directories with two files each. >> $ git init >> Initialized empty Git repository in /tmp/.git/ >> $ mkdir a b >> $ echo x >a/equal >> $ echo x >b/equal >> $ echo y >a/different >> $ echo z >b/

Re: Bug report about symlinks

2014-08-01 Thread Dennis Kaarsemaker
On wo, 2014-07-30 at 15:30 +0400, NickKolok wrote: > Greetings from Russia, comrads! > > I've noticed something strange with git status when replacing a folder with > symlink to another folder. > There is a git repo with script with demo in the attachment. I think there is a bug here: + mkdir b

Re: Bug report about symlinks

2014-08-01 Thread Junio C Hamano
René Scharfe writes: > # Create test repo with two directories with two files each. > $ git init > Initialized empty Git repository in /tmp/.git/ > $ mkdir a b > $ echo x >a/equal > $ echo x >b/equal > $ echo y >a/different > $ echo z >b/different > $ git add a b > $ git commit -minitial > [maste

Re: Bug report about symlinks

2014-07-31 Thread René Scharfe
Am 31.07.2014 um 21:50 schrieb Nikolay Avdeev: I've noticed something strange with git status when replacing a folder with symlink to another folder. There is a git repo with script with demo in the attachment. Let's try and make this a bit easier for folks to follow along. # Create test repo

Bug report about symlinks

2014-07-31 Thread Nikolay Avdeev
Greetings from Russia, comrads! I've noticed something strange with git status when replacing a folder with symlink to another folder. There is a git repo with script with demo in the attachment. Yours sincerely, NickKolok aka Nikolay Avdeev. Доброго времени суток, товарищи! При замене папки на

Bug report about symlinks

2014-07-30 Thread NickKolok
Greetings from Russia, comrads! I've noticed something strange with git status when replacing a folder with symlink to another folder. There is a git repo with script with demo in the attachment. Yours sincerely, NickKolok aka Nikolay Avdeev. Доброго времени суток, товарищи! При замене папки