Re: Bug in reflog of length 0x2BFF

2014-12-04 Thread Junio C Hamano
Jeff King writes: > I think the bug is in the reverse-reflog reader in > for_each_reflog_ent_reverse. It reads BUFSIZ chunks of the file in > reverse order, and then parses them individually. If the trailing > newline for a line falls directly on the block boundary, we may not have > it in our cu

Re: Bug in reflog of length 0x2BFF

2014-12-04 Thread Junio C Hamano
Christoph Mallon writes: >> Amen to that. I am getting the same thing. > > I ran reproduce it reliably on multiple machines (OS X, FreeBSD, ia32, Oh, I do not doubt you see a problem. I am just saying that I don't have an easy entry to the issue without it reproducing for me. -- To unsubscribe

Re: Bug in reflog of length 0x2BFF

2014-12-04 Thread Jeff King
On Thu, Dec 04, 2014 at 09:37:34PM +0100, Christoph Mallon wrote: > Am 04.12.14 21:18, schrieb Junio C Hamano: > > Jonathan Nieder writes: > >> Could you make a test script that illustrates and reproduces the > >> problem? I.e., a patch to a file like t/t1410-reflog.sh, such that > >> if I run >

Re: Bug in reflog of length 0x2BFF

2014-12-04 Thread Christoph Mallon
Am 04.12.14 21:18, schrieb Junio C Hamano: > Jonathan Nieder writes: >> Could you make a test script that illustrates and reproduces the >> problem? I.e., a patch to a file like t/t1410-reflog.sh, such that >> if I run >> >> cd git >> make >> cd t >> ./t1410-reflog.sh >> >> th

Re: Bug in reflog of length 0x2BFF

2014-12-04 Thread Junio C Hamano
Jonathan Nieder writes: > Christoph Mallon wrote: > >> % git rev-parse 'master@{52}' >> warning: Log for ref refs/heads/master has gap after Thu, 1 Jan 1970 >> 00:00:01 +. >> 0036 > > Can you say more? What output did you expect and how does this differ >

Re: Bug in reflog of length 0x2BFF

2014-12-01 Thread Christoph Mallon
Hi Jonathan, Am 02.12.14 00:35, schrieb Jonathan Nieder: > Christoph Mallon wrote: >> % git rev-parse 'master@{52}' >> warning: Log for ref refs/heads/master has gap after Thu, 1 Jan 1970 >> 00:00:01 +. >> 0036 > > Can you say more? What output did you ex

Re: Bug in reflog of length 0x2BFF

2014-12-01 Thread Stefan Beller
Hi, so I have installed git version 2.2.0 currently, because I was trying to reproduce "Bug in reflog of length 0x2BFF". Now I was using git as a normal user, rebasing some stuff (incidentally the reflog improvements) and an error occurred: $ git rebase --continue error: Ref

Re: Bug in reflog of length 0x2BFF

2014-12-01 Thread Jonathan Nieder
Hi Christoph, Christoph Mallon wrote: > % git rev-parse 'master@{52}' > warning: Log for ref refs/heads/master has gap after Thu, 1 Jan 1970 00:00:01 > +. > 0036 Can you say more? What output did you expect and how does this differ from it? I tried, wit

Re: Bug in reflog of length 0x2BFF

2014-12-01 Thread Christoph Mallon
Am 01.12.14 19:53, schrieb Stefan Beller: > So I am running a 3.13.0-40-generic x86_64 linux (so its's amd64) and > git version 2.1.2 > and I cannot reproduce the bug you are describing. :( ): I can reproduce it with * OS X, i386 binary, git 2.2.0 * FreeBSD, amd64, git 2.1.0 and up (bisected it t

Re: Bug in reflog of length 0x2BFF

2014-12-01 Thread Stefan Beller
So I am running a 3.13.0-40-generic x86_64 linux (so its's amd64) and git version 2.1.2 and I cannot reproduce the bug you are describing. :( $ git rev-parse 'master@{52}' 0035 What I noticed though is there are 2 linefeeds at the end of each line, is that inte

Re: Bug in reflog of length 0x2BFF

2014-12-01 Thread Christoph Mallon
This commit seems to introduce the bug: 4207ed285f31ad3e04f08254237c0c1a1609642b -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Bug in reflog of length 0x2BFF

2014-12-01 Thread Christoph Mallon
Hi, I encountered a strange bug concerning the reflog. I suspect some kind of out-of-bounds access. The symptom is: %git rev-parse 'master@{52}' warning: Log for ref refs/heads/master has gap after Thu, 1 Jan 1970 00:00:01 +. 0036 Try the following: git i