Re: Bug: git-push crash due to double-close of file descriptor

2013-10-22 Thread Duy Nguyen
On Tue, Oct 22, 2013 at 5:49 PM, Duy Nguyen wrote: > set fd[1] = 0 I thought fd[1] = -1, I wrote fd[1] = 0 :( -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-in

Re: Bug: git-push crash due to double-close of file descriptor

2013-10-22 Thread Duy Nguyen
On Tue, Oct 22, 2013 at 5:25 PM, Jens Lindström wrote: > In a repository, I have a repeatable crash when pushing a ref to a > remote. The cause seems very simple, and it's more unclear to me why > this doesn't happen more often. > > The cause, as I understand it: > > git_transport_push() calls sen

Bug: git-push crash due to double-close of file descriptor

2013-10-22 Thread Jens Lindström
In a repository, I have a repeatable crash when pushing a ref to a remote. The cause seems very simple, and it's more unclear to me why this doesn't happen more often. The cause, as I understand it: git_transport_push() calls send_pack() which calls pack_objects() which calls start_command(), whi