Re: Adding nested repository with slash adds files instead of gitlink

2018-06-20 Thread Rafael Ascensão
On Tue, Jun 19, 2018 at 11:28 AM Heiko Voigt wrote: > > Interesting and nobody complained to the mailinglist? > On Wed, Jun 20, 2018 at 3:57 PM Duy Nguyen wrote: > > Abusing a long standing bug does not make it a feature. > To make things clear, I wasn't defending if this should be considered a

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-20 Thread Duy Nguyen
On Wed, Jun 20, 2018 at 1:55 PM Rafael Ascensão wrote: > > On Wed, Jun 20, 2018 at 5:39 AM Kevin Daudt wrote: > > > > What this is about that when doing `git add path/` (with trailing /), > > > > This is what I was referring to. If you search for 'Fake Submodules', > you'll see that some people w

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-20 Thread Rafael Ascensão
On Wed, Jun 20, 2018 at 5:39 AM Kevin Daudt wrote: > > What this is about that when doing `git add path/` (with trailing /), > This is what I was referring to. If you search for 'Fake Submodules', you'll see that some people were/are intentionally using this instead of subtrees or submodules. Unf

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Kevin Daudt
On Tue, Jun 19, 2018 at 11:29:02PM +0100, Rafael Ascensão wrote: > On Tue, Jun 19, 2018 at 11:28 AM Heiko Voigt wrote: > > > > Interesting and nobody complained to the mailinglist? > > > > For reference this was sometimes called "Fake Submodules" online. Do you refer to cloning a repository in a

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Rafael Ascensão
On Tue, Jun 19, 2018 at 11:28 AM Heiko Voigt wrote: > > Interesting and nobody complained to the mailinglist? > For reference this was sometimes called "Fake Submodules" online.

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 6:09 PM Duy Nguyen wrote: > On Tue, Jun 19, 2018 at 05:16:17PM +0200, Duy Nguyen wrote: > > No actually, we could do better. Let me see if I can come up with a > > patch or something... > > OK. What we currently do is, when we search for potential untracked > paths for addi

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 05:16:17PM +0200, Duy Nguyen wrote: > No actually, we could do better. Let me see if I can come up with a > patch or something... OK. What we currently do is, when we search for potential untracked paths for adding to the index, we unconditionally ignore anything inside ".g

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 5:56 PM Junio C Hamano wrote: > > Duy Nguyen writes: > > > On Tue, Jun 19, 2018 at 12:36 PM Heiko Voigt wrote: > >> > >> On Mon, Jun 18, 2018 at 11:12:15AM -0700, Brandon Williams wrote: > >> > On 06/18, Duy Nguyen wrote: > >> > > This sounds like the submodule specific c

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Jun 19, 2018 at 12:36 PM Heiko Voigt wrote: >> >> On Mon, Jun 18, 2018 at 11:12:15AM -0700, Brandon Williams wrote: >> > On 06/18, Duy Nguyen wrote: >> > > This sounds like the submodule specific code in pathspec.c, which has >> > > been replaced with something else

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 12:36 PM Heiko Voigt wrote: > > On Mon, Jun 18, 2018 at 11:12:15AM -0700, Brandon Williams wrote: > > On 06/18, Duy Nguyen wrote: > > > This sounds like the submodule specific code in pathspec.c, which has > > > been replaced with something else in bw/pathspec-sans-the-inde

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Heiko Voigt
On Mon, Jun 18, 2018 at 11:12:15AM -0700, Brandon Williams wrote: > On 06/18, Duy Nguyen wrote: > > This sounds like the submodule specific code in pathspec.c, which has > > been replaced with something else in bw/pathspec-sans-the-index. If > > you have time, try a version without those changes (e

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-19 Thread Heiko Voigt
Hi, On Mon, Jun 18, 2018 at 05:55:44PM +0200, Kevin Daudt wrote: > On Mon, Jun 18, 2018 at 01:19:19PM +0200, Heiko Voigt wrote: > > I just discovered that when you have a slash at the end of a nested > > repository, the files contained in the repository get added instead of > > the gitlink. [...]

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-18 Thread Brandon Williams
On 06/18, Duy Nguyen wrote: > On Mon, Jun 18, 2018 at 1:23 PM Heiko Voigt wrote: > > > > Hi, > > > > I just discovered that when you have a slash at the end of a nested > > repository, the files contained in the repository get added instead of > > the gitlink. > > > > I found this when I was addin

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-18 Thread Kevin Daudt
On Mon, Jun 18, 2018 at 01:19:19PM +0200, Heiko Voigt wrote: Now with cc to the mailing list. > Hi, > > I just discovered that when you have a slash at the end of a nested > repository, the files contained in the repository get added instead of > the gitlink. > > I found this when I was adding

Re: Adding nested repository with slash adds files instead of gitlink

2018-06-18 Thread Duy Nguyen
On Mon, Jun 18, 2018 at 1:23 PM Heiko Voigt wrote: > > Hi, > > I just discovered that when you have a slash at the end of a nested > repository, the files contained in the repository get added instead of > the gitlink. > > I found this when I was adding a submodule and wanted to commit a small > c

Adding nested repository with slash adds files instead of gitlink

2018-06-18 Thread Heiko Voigt
Hi, I just discovered that when you have a slash at the end of a nested repository, the files contained in the repository get added instead of the gitlink. I found this when I was adding a submodule and wanted to commit a small change before that. You get the slash by using tab autocompletion. H